From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Calling Lisp from undo.c's record_* functions Date: Tue, 17 Nov 2015 21:55:24 -0500 Message-ID: References: <83r3jpc2of.fsf@gnu.org> <87h9kkbz6k.fsf@russet.org.uk> <87d1v8bsbf.fsf@russet.org.uk> <83bnasbnlq.fsf@gnu.org> <87fv04mj9i.fsf@russet.org.uk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1447815366 17132 80.91.229.3 (18 Nov 2015 02:56:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Nov 2015 02:56:06 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 18 03:55:56 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZysuX-0002OI-3a for ged-emacs-devel@m.gmane.org; Wed, 18 Nov 2015 03:55:53 +0100 Original-Received: from localhost ([::1]:33458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZysuW-0000gJ-D4 for ged-emacs-devel@m.gmane.org; Tue, 17 Nov 2015 21:55:52 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZysuA-0000gE-UK for emacs-devel@gnu.org; Tue, 17 Nov 2015 21:55:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zysu6-0000op-Sm for emacs-devel@gnu.org; Tue, 17 Nov 2015 21:55:30 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:59103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zysu6-0000ok-Na; Tue, 17 Nov 2015 21:55:26 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id tAI2tOm9029602; Tue, 17 Nov 2015 21:55:24 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 1C6C066157; Tue, 17 Nov 2015 21:55:24 -0500 (EST) In-Reply-To: <87fv04mj9i.fsf@russet.org.uk> (Phillip Lord's message of "Tue, 17 Nov 2015 21:02:49 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5493=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5493> : inlines <4006> : streams <1539884> : uri <2084887> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194688 Archived-At: > As far as I can tell, changing a text property will result in changes to > the undo list, but doesn't call prepare_to_modify_buffer. Rather > modify_text_properties appears to call prepare_to_modify_buffer_1 > directly. Bit surprising -- I wouldn't have expected a function called > "blah_1" to be called directly from anywhere other than "blah". Ah, so maybe the call to run_undoable_change should be in prepare_to_modify_buffer_1 rather than in prepare_to_modify_buffer. I haven't actually looked at the code. Stefan