From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Stephen Leake <stephen_leake@stephe-leake.org>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: make project--find-in-file generic, add interactive filename to project-find-file
Date: Sun, 31 Jan 2016 01:18:15 -0500 [thread overview]
Message-ID: <jwv37tep9cm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <56ABDF5F.30404@yandex.ru> (Dmitry Gutov's message of "Sat, 30 Jan 2016 00:53:35 +0300")
> (defun completing-read-strict (prompt
> collection &optional predicate
> hist default inherit-input-method)
I think `default' should come earlier, maybe even before `&optional'.
> I can use it in completing-read-strict to satisfy both points mentioned
> previously. But after trying it out, I'm not sure about the general
> applicability of the DEFAULT semantics here. It just seems awkward:
You can probably get a cleaner behavior if you change
minibuffer-complete-and-exit so that it does most of the new work (but
only when called from completing-read-strict).
> And as long as completing-read-strict, by itself, does allow the case of
> "default that doesn't match anything", that makes me doubt its semantics.
We could check `default' directly when we receive it, but I'd rather not
do that:
- it would ruin efforts to make completion tables more lazy.
- it's rarely useful, but in 99% of the cases, we already know that
the default is a valid value.
But yes, it should probably be considered "bad karma" for the caller to
provide an invalid `default'.
Stefan
next prev parent reply other threads:[~2016-01-31 6:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 1:04 make project--find-in-file generic, add interactive filename to project-find-file Stephen Leake
2016-01-28 9:21 ` Dmitry Gutov
2016-01-28 10:11 ` Stephen Leake
2016-01-28 10:36 ` Dmitry Gutov
2016-01-28 13:14 ` Stefan Monnier
2016-01-28 19:32 ` Dmitry Gutov
2016-01-28 21:11 ` Stefan Monnier
2016-01-28 21:22 ` Dmitry Gutov
2016-01-28 22:44 ` Stefan Monnier
2016-01-29 2:10 ` Dmitry Gutov
2016-01-29 2:57 ` Stefan Monnier
2016-01-29 4:20 ` Dmitry Gutov
2016-01-29 14:05 ` Stefan Monnier
2016-01-29 21:53 ` Dmitry Gutov
2016-01-31 6:18 ` Stefan Monnier [this message]
2016-01-31 14:02 ` Dmitry Gutov
2016-01-31 14:23 ` Stefan Monnier
2016-02-01 8:08 ` Dmitry Gutov
2016-02-01 13:40 ` Stefan Monnier
2016-01-29 2:05 ` Dmitry Gutov
2016-01-29 2:55 ` Stefan Monnier
2016-01-29 4:11 ` Dmitry Gutov
2016-01-29 14:03 ` Stefan Monnier
2016-01-29 21:35 ` Dmitry Gutov
2016-01-30 2:07 ` Stefan Monnier
2016-01-30 23:32 ` Juri Linkov
2016-01-31 0:40 ` Dmitry Gutov
2016-01-28 11:06 ` Stephen Leake
2016-01-28 11:11 ` Stephen Leake
2016-01-29 2:18 ` Dmitry Gutov
2016-01-29 23:55 ` Stephen Leake
2016-01-30 0:15 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv37tep9cm.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).