unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* non-fast-forward pushes to Emacs Git repo "scratch" branches?
@ 2016-06-17 13:43 Ted Zlatanov
  2016-06-17 22:25 ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Ted Zlatanov @ 2016-06-17 13:43 UTC (permalink / raw)
  To: emacs-devel

Can the Emacs Git repo allow non-fast-forward pushes to "scratch/*"
branches? Those are never released so it wouldn't compromise the
integrity of the public source code.

Thanks
Ted




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: non-fast-forward pushes to Emacs Git repo "scratch" branches?
  2016-06-17 13:43 non-fast-forward pushes to Emacs Git repo "scratch" branches? Ted Zlatanov
@ 2016-06-17 22:25 ` Stefan Monnier
  2016-06-17 23:08   ` John Wiegley
                     ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Stefan Monnier @ 2016-06-17 22:25 UTC (permalink / raw)
  To: emacs-devel

> Can the Emacs Git repo allow non-fast-forward pushes to "scratch/*"
> branches?

No, because the non-fast-forward constraint is applied globally.
But you can delete a branch and then push a new branch under the same
name, with the same end result.

I don't know if John would object to it, and I don't think this has
already been used in the past, but when I suggested the use of
the "scratch/" prefix, I did assume that such "rebasing" would be used
there occasionally.


        Stefan




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: non-fast-forward pushes to Emacs Git repo "scratch" branches?
  2016-06-17 22:25 ` Stefan Monnier
@ 2016-06-17 23:08   ` John Wiegley
  2016-06-18 10:23   ` Ted Zlatanov
  2016-06-20 15:21   ` Phillip Lord
  2 siblings, 0 replies; 6+ messages in thread
From: John Wiegley @ 2016-06-17 23:08 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:

> I don't know if John would object to it, and I don't think this has already
> been used in the past, but when I suggested the use of the "scratch/"
> prefix, I did assume that such "rebasing" would be used there occasionally.

I don't object to anything done in scratch. It's scratch; track its branches
with caution.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 629 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: non-fast-forward pushes to Emacs Git repo "scratch" branches?
  2016-06-17 22:25 ` Stefan Monnier
  2016-06-17 23:08   ` John Wiegley
@ 2016-06-18 10:23   ` Ted Zlatanov
  2016-06-20 15:21   ` Phillip Lord
  2 siblings, 0 replies; 6+ messages in thread
From: Ted Zlatanov @ 2016-06-18 10:23 UTC (permalink / raw)
  To: emacs-devel

On Fri, 17 Jun 2016 18:25:13 -0400 Stefan Monnier <monnier@iro.umontreal.ca> wrote: 

>> Can the Emacs Git repo allow non-fast-forward pushes to "scratch/*"
>> branches?

SM> No, because the non-fast-forward constraint is applied globally.
SM> But you can delete a branch and then push a new branch under the same
SM> name, with the same end result.

SM> I don't know if John would object to it, and I don't think this has
SM> already been used in the past, but when I suggested the use of
SM> the "scratch/" prefix, I did assume that such "rebasing" would be used
SM> there occasionally.

Perfect, thanks.

Ted




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: non-fast-forward pushes to Emacs Git repo "scratch" branches?
  2016-06-17 22:25 ` Stefan Monnier
  2016-06-17 23:08   ` John Wiegley
  2016-06-18 10:23   ` Ted Zlatanov
@ 2016-06-20 15:21   ` Phillip Lord
  2016-06-23 14:18     ` Ted Zlatanov
  2 siblings, 1 reply; 6+ messages in thread
From: Phillip Lord @ 2016-06-20 15:21 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Can the Emacs Git repo allow non-fast-forward pushes to "scratch/*"
>> branches?
>
> No, because the non-fast-forward constraint is applied globally.
> But you can delete a branch and then push a new branch under the same
> name, with the same end result.

It is possible to enforce this on a per branch basis. Just applying it
on master and anything starting with "emacs" (for release branches)
would do the trick.

It would also be possible to prevent, for example, accidental deletions
of emacs-25, or master as well as enforce the "don't check into emacs-25
without asking" rule.

All good things for newer developers.

Phil



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: non-fast-forward pushes to Emacs Git repo "scratch" branches?
  2016-06-20 15:21   ` Phillip Lord
@ 2016-06-23 14:18     ` Ted Zlatanov
  0 siblings, 0 replies; 6+ messages in thread
From: Ted Zlatanov @ 2016-06-23 14:18 UTC (permalink / raw)
  To: emacs-devel

On Mon, 20 Jun 2016 16:21:25 +0100 phillip.lord@russet.org.uk (Phillip Lord) wrote: 

PL> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> Can the Emacs Git repo allow non-fast-forward pushes to "scratch/*"
>>> branches?
>> 
>> No, because the non-fast-forward constraint is applied globally.
>> But you can delete a branch and then push a new branch under the same
>> name, with the same end result.

PL> It is possible to enforce this on a per branch basis. Just applying it
PL> on master and anything starting with "emacs" (for release branches)
PL> would do the trick.

PL> It would also be possible to prevent, for example, accidental deletions
PL> of emacs-25, or master as well as enforce the "don't check into emacs-25
PL> without asking" rule.

I'd be excited to see these improvements. Another is to enforce the
commit message formatting.

I don't have access to the relevant infrastructure, unfortunately. I
imagine it's a matter of modifying the receive hook scripts. Can I help
make it happen?

Thanks
Ted




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-06-23 14:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-17 13:43 non-fast-forward pushes to Emacs Git repo "scratch" branches? Ted Zlatanov
2016-06-17 22:25 ` Stefan Monnier
2016-06-17 23:08   ` John Wiegley
2016-06-18 10:23   ` Ted Zlatanov
2016-06-20 15:21   ` Phillip Lord
2016-06-23 14:18     ` Ted Zlatanov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).