Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a

unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed

* Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a
       [not found] ` <20160721205320.09141220159@vcs.savannah.gnu.org>
@ 2016-07-21 21:00   ` Stefan Monnier
  2016-07-21 21:04     ` Mark Oteiza
  2016-07-22 18:26     ` John Wiegley
  0 siblings, 2 replies; 5+ messages in thread
From: Stefan Monnier @ 2016-07-21 21:00 UTC (permalink / raw)
  To: emacs-devel; +Cc: Mark Oteiza

> -  (add-function :override (local 'prettify-symbols-compose-predicate)
> -                #'tex--prettify-symbols-compose-p)
> +  (setq-local prettify-symbols-compose-predicate #'tex--prettify-symbols-compose-p)

Actually, I prefer the add-function version, as can be seen by the fact
that I installed a patch which uses it.  And if you look at the commit
history, you'll see that I'm about as close to "maintainer of
tex-mode.el" as there is, so please revert your reversion unless you
have a concrete reason for it (not just "taste" on which we simply
differ and neither can claim that the other one is wrong).

        Stefan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a
  2016-07-21 21:00   ` [Emacs-diffs] master b765164: ;Partially revert 2649105a Stefan Monnier
@ 2016-07-21 21:04     ` Mark Oteiza
  2016-07-21 21:14       ` Stefan Monnier
  2016-07-22 18:26     ` John Wiegley
  1 sibling, 1 reply; 5+ messages in thread
From: Mark Oteiza @ 2016-07-21 21:04 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

On 21/07/16 at 05:00pm, Stefan Monnier wrote:
> > -  (add-function :override (local 'prettify-symbols-compose-predicate)
> > -                #'tex--prettify-symbols-compose-p)
> > +  (setq-local prettify-symbols-compose-predicate #'tex--prettify-symbols-compose-p)
> 
> Actually, I prefer the add-function version, as can be seen by the fact
> that I installed a patch which uses it.  And if you look at the commit
> history, you'll see that I'm about as close to "maintainer of
> tex-mode.el" as there is, so please revert your reversion unless you
> have a concrete reason for it (not just "taste" on which we simply
> differ and neither can claim that the other one is wrong).

Oh, I took
https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00816.html
as reason.  Will revert.

OOC, what patch uses it?



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a
  2016-07-21 21:04     ` Mark Oteiza
@ 2016-07-21 21:14       ` Stefan Monnier
  2016-07-21 21:15         ` Mark Oteiza
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2016-07-21 21:14 UTC (permalink / raw)
  To: Mark Oteiza; +Cc: emacs-devel

> Oh, I took
> https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00816.html
> as reason.  Will revert.

No I was just agreeing that it's not a tremendously useful use of
add-function.  I still prefer this "overkill" form, because in general
it behaves better (e.g. it can be useful in case someone uses this code
as inspiration elsewhere where the difference does matter).

> OOC, what patch uses it?

I was referring to the inverse patch to the one you installed (i.e. to
the patch that uses add-function, rather than to a patch which uses
that patch).

        Stefan

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a
  2016-07-21 21:14       ` Stefan Monnier
@ 2016-07-21 21:15         ` Mark Oteiza
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Oteiza @ 2016-07-21 21:15 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

On 21/07/16 at 05:14pm, Stefan Monnier wrote:
> > Oh, I took
> > https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00816.html
> > as reason.  Will revert.
> 
> No I was just agreeing that it's not a tremendously useful use of
> add-function.  I still prefer this "overkill" form, because in general
> it behaves better (e.g. it can be useful in case someone uses this code
> as inspiration elsewhere where the difference does matter).

Oh, I see. Sorry about that--done.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a
  2016-07-21 21:00   ` [Emacs-diffs] master b765164: ;Partially revert 2649105a Stefan Monnier
  2016-07-21 21:04     ` Mark Oteiza
@ 2016-07-22 18:26     ` John Wiegley
  1 sibling, 0 replies; 5+ messages in thread
From: John Wiegley @ 2016-07-22 18:26 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Mark Oteiza, emacs-devel

>>>>> "SM" == Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

SM> Actually, I prefer the add-function version, as can be seen by the fact
SM> that I installed a patch which uses it. And if you look at the commit
SM> history, you'll see that I'm about as close to "maintainer of tex-mode.el"
SM> as there is, so please revert your reversion unless you have a concrete
SM> reason for it (not just "taste" on which we simply differ and neither can
SM> claim that the other one is wrong).

Stefan, you missed a perfect opportunity to have said:

  So please revert your reversion unless you have a concrete aversion.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-07-22 18:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20160721205319.22541.75336@vcs.savannah.gnu.org>
     [not found] ` <20160721205320.09141220159@vcs.savannah.gnu.org>
2016-07-21 21:00   ` [Emacs-diffs] master b765164: ;Partially revert 2649105a Stefan Monnier
2016-07-21 21:04     ` Mark Oteiza
2016-07-21 21:14       ` Stefan Monnier
2016-07-21 21:15         ` Mark Oteiza
2016-07-22 18:26     ` John Wiegley

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).