From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master b765164: ;Partially revert 2649105a Date: Thu, 21 Jul 2016 17:14:54 -0400 Message-ID: References: <20160721205319.22541.75336@vcs.savannah.gnu.org> <20160721205320.09141220159@vcs.savannah.gnu.org> <20160721210445.GA2283@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469135629 20715 80.91.229.3 (21 Jul 2016 21:13:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 21:13:49 +0000 (UTC) Cc: emacs-devel@gnu.org To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 21 23:13:39 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQLHl-0007M6-OC for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 23:13:37 +0200 Original-Received: from localhost ([::1]:43753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQLHk-0000xv-O0 for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 17:13:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQLHe-0000xn-HD for emacs-devel@gnu.org; Thu, 21 Jul 2016 17:13:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQLHb-0005D6-RD for emacs-devel@gnu.org; Thu, 21 Jul 2016 17:13:30 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:48278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQLHb-0005D0-MD for emacs-devel@gnu.org; Thu, 21 Jul 2016 17:13:27 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u6LLDlqk017063; Thu, 21 Jul 2016 17:13:47 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id DF8DB6025B; Thu, 21 Jul 2016 17:14:54 -0400 (EDT) In-Reply-To: <20160721210445.GA2283@holos.localdomain> (Mark Oteiza's message of "Thu, 21 Jul 2016 17:04:45 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered TRK_NCM1=0.2, RV5742=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5742> : inlines <5025> : streams <1671450> : uri <2252385> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205998 Archived-At: > Oh, I took > https://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00816.html > as reason. Will revert. No I was just agreeing that it's not a tremendously useful use of add-function. I still prefer this "overkill" form, because in general it behaves better (e.g. it can be useful in case someone uses this code as inspiration elsewhere where the difference does matter). > OOC, what patch uses it? I was referring to the inverse patch to the one you installed (i.e. to the patch that uses add-function, rather than to a patch which uses that patch). Stefan