unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: What’s the deal with #if _LIBC and other non-Emacs code?
Date: Tue, 26 Jul 2016 12:06:20 -0400	[thread overview]
Message-ID: <jwv37mwtmzq.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 83wpk8s8zh.fsf@gnu.org

>> > I wasn't aware we made such a decision.
>> That's not a decision we took.  The change was on gnulib's side
>> (apparently they switched to glibc's regexp implementation, which makes
>> a lot of sense, actually).
> I meant the decision to abandon hope of merging.

AFAIK the code used in gnulib and glibc is very completely different
from Emacs's, so "merging" back into their code is not really
applicable.  We could try and take their code, add to it the features we
need, and then submit those changes back to them, tho.


        Stefan


PS: I'm not sure exactly what would be missing, but I expect that \s and
\c together with the ability to match on a pair of char* would be the
first candidates.

PPS: I think the most serious problem with our regexp code is its
occasional exponential worst case.  I think changing to another
implementation would make a lot of sense, but only if that other
implementation can use a "Thompson's NFA" style implementation to avoid
those pathological cases.




      reply	other threads:[~2016-07-26 16:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25 22:58 What’s the deal with #if _LIBC and other non-Emacs code? Michal Nazarewicz
2016-07-26  2:34 ` Eli Zaretskii
2016-07-26  2:42   ` Stefan Monnier
2016-07-26  6:50     ` Paul Eggert
2016-07-26 14:51     ` Eli Zaretskii
2016-07-26 15:33       ` Stefan Monnier
2016-07-26 15:40         ` Eli Zaretskii
2016-07-26 16:06           ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv37mwtmzq.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).