From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile
Date: Tue, 20 Dec 2016 09:53:23 -0500 [thread overview]
Message-ID: <jwv37hid5nk.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <dc141dda-ceb2-04da-c295-dff0085c5265@jacksonrayhamilton.com> (Jackson Ray Hamilton's message of "Mon, 19 Dec 2016 22:04:23 -0800")
> Sorry, I didn't even notice the slowdown; I see now that it went from
> 0.9s to 1.9s on my machine.
>
> The first attached patch is simple and speeds it up to 1.65s.
>
> The second attached patch sort of re-implements what tar would do, using
> sh case, but it's more complex. It clocks in at 1.35s after that.
[ If we can use `tar` it seems better, indeed. BTW we need to be careful
to try and make it difficult for a committer to elpa.git to get access
to elpa.gnu.org via this script (I'm thinking of a commit that adds
files with names that contain funny chars like space, ;, etc...). ]
But they both restrict the .el files to be in the top-level directory,
and the source of the problem that lead to this discussion is that
I want to byte-compile also those files that are inside sub-directories
(even though we don't currently do that).
I think we could optimize the code in other ways:
- currently `make` is invoked twice (once recursively to build `elcs`),
so this computation of included_els is performed twice. I'd be great to get
rid of this redundancy.
- only use `tar` if there is a .elpaignore, and just use
something like $(wildcard *.el */*.el */*/*.el) in the other case.
- only check .elpaignore for *changes*. I.e. cache the previous computation
somehow. One way is to only check .elpaignore for those files which don't
have a corresponding .elc.
Stefan
prev parent reply other threads:[~2016-12-20 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160805013757.31623.20092@vcs.savannah.gnu.org>
[not found] ` <20160805013758.9B5BB2201A4@vcs.savannah.gnu.org>
2016-08-06 17:42 ` [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile Jackson Hamilton
2016-08-06 18:29 ` Stefan Monnier
2016-12-18 0:06 ` Jackson Ray Hamilton
2016-12-18 3:18 ` Stefan Monnier
2016-12-19 2:43 ` Jackson Ray Hamilton
2016-12-19 14:49 ` Stefan Monnier
2016-12-20 6:04 ` Jackson Ray Hamilton
2016-12-20 14:53 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv37hid5nk.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jackson@jacksonrayhamilton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).