From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: The current state of the comment-cache branch Date: Fri, 23 Dec 2016 20:32:42 -0500 Message-ID: References: <20161223215056.GA2771@acm.fritz.box> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482543193 20782 195.159.176.226 (24 Dec 2016 01:33:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Dec 2016 01:33:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 24 02:33:09 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKbCs-0004Tx-Os for ged-emacs-devel@m.gmane.org; Sat, 24 Dec 2016 02:33:06 +0100 Original-Received: from localhost ([::1]:41540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKbCx-0007N2-7W for ged-emacs-devel@m.gmane.org; Fri, 23 Dec 2016 20:33:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKbCp-0007Mv-HS for emacs-devel@gnu.org; Fri, 23 Dec 2016 20:33:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKbCk-0001iS-MZ for emacs-devel@gnu.org; Fri, 23 Dec 2016 20:33:03 -0500 Original-Received: from [195.159.176.226] (port=46968 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKbCk-0001hL-GW for emacs-devel@gnu.org; Fri, 23 Dec 2016 20:32:58 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cKbCZ-00025h-Dh for emacs-devel@gnu.org; Sat, 24 Dec 2016 02:32:47 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:QlaAFPiTzQx0cUcwRoGQsV3fZH4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210765 Archived-At: > I would like the comment-cache code to be merged into master soon. This message is probably redundant, but just to make it clear: I'm opposed to this change as it is because I find its cost/benefit tradeoff to be poor. I don't think solving some rare pathological case of (forward-comment -1) deserves this complexity. I think we'd be better off with either: - a simpler change, to reduce the cost part of the tradeoff (such as the one I suggested, using syntax-ppss; such a change might make extra demands on syntax-ppss which will require further "refinement" to syntax-ppss, but these refinements are needed in any case, so are not an argument against that change, but only an argument to delay the change). - a more thorough change, to improve the benefit (i.e. make your "comment-cache" able to provide the same kind of information that we currently get via syntax-ppss, so it can supersede syntax-ppss). Stefan