From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Should diff.elisp.xfuncname match cl-lib macros? Date: Sat, 16 Mar 2019 14:14:17 -0400 Message-ID: References: <87wol0qecg.fsf@tcd.ie> <87a7hug7ld.fsf@tcd.ie> <83imwiydnr.fsf@gnu.org> <83h8c2ybaa.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="161999"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 16 19:16:25 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h5Dr6-000g2K-Ds for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 19:16:24 +0100 Original-Received: from localhost ([127.0.0.1]:44800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5Dr5-0001Tr-99 for ged-emacs-devel@m.gmane.org; Sat, 16 Mar 2019 14:16:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h5Dqw-0001T6-Uq for emacs-devel@gnu.org; Sat, 16 Mar 2019 14:16:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h5DpC-0005cQ-3h for emacs-devel@gnu.org; Sat, 16 Mar 2019 14:14:26 -0400 Original-Received: from [195.159.176.226] (port=59440 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h5DpB-0005cA-O9 for emacs-devel@gnu.org; Sat, 16 Mar 2019 14:14:26 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1h5Dp9-000dwQ-Ea for emacs-devel@gnu.org; Sat, 16 Mar 2019 19:14:23 +0100 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:NaOVOG/Jm5dhgFTSkWiarPAGomU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234234 Archived-At: >> AFAIK xfuncname is mostly used to add the "containing function name" >> on the header of each diff hunk. > That's a million times less important to me than "git log -L". Indeed, it's not an important feature at all. It's just a nice "frill". Given the inevitable unreliability of the info it gets, I'm surprised it grew to take a more significant role in -L. I guess it's still worthwhile in the sense that it's good when it works and when it doesn't you're no worse off than if you didn't have that feature. Stefan