From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master bc2a93d: Fix more regular expression typos
Date: Wed, 20 Mar 2019 08:26:11 -0400 [thread overview]
Message-ID: <jwv36nhrb10.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20190319000239.D3DC7209E0@vcs0.savannah.gnu.org> (Paul Eggert's message of "Mon, 18 Mar 2019 20:02:37 -0400 (EDT)")
> diff --git a/lisp/pcomplete.el b/lisp/pcomplete.el
> index d4ee2c3..ef285db 100644
> --- a/lisp/pcomplete.el
> +++ b/lisp/pcomplete.el
> @@ -768,7 +768,7 @@ this is `comint-dynamic-complete-functions'."
> (push (point) begins)
> (while
> (progn
> - (skip-chars-forward "^ \t\n\\")
> + (skip-chars-forward "^ \t\n")
> (when (eq (char-after) ?\\)
> (forward-char 1)
> (unless (eolp)
Hmm... no this needs to be
(skip-chars-forward "^ \t\n\\")
or
(skip-chars-forward "^ \t\n\\\\")
-- Stefan "who happened to look at it right now"
next parent reply other threads:[~2019-03-20 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190319000234.5983.14812@vcs0.savannah.gnu.org>
[not found] ` <20190319000239.D3DC7209E0@vcs0.savannah.gnu.org>
2019-03-20 12:26 ` Stefan Monnier [this message]
2019-03-20 13:01 ` [Emacs-diffs] master bc2a93d: Fix more regular expression typos Mattias Engdegård
2019-03-20 13:14 ` Stefan Monnier
2019-03-20 13:33 ` Mattias Engdegård
2019-03-20 16:24 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv36nhrb10.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).