From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Predicate for true lists Date: Tue, 09 Apr 2019 11:33:59 -0400 Message-ID: References: <87fu3vdjjk.fsf@tcd.ie> <87bmcqhhsf.fsf@tcd.ie> <87in6xgtpb.fsf@tcd.ie> <2af892df-26cb-60b2-4fd8-067fcb3d32e9@cs.ucla.edu> <87r2kh9uwx.fsf@tcd.ie> <83h8lcnbxb.fsf@gnu.org> <87sh4s9poo.fsf@tcd.ie> <87k1q49p0i.fsf@tcd.ie> <87efgbbq2p.fsf@tcd.ie> <87a7gz8hp2.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="213718"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 09 17:34:20 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDslP-000tT5-EZ for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 17:34:19 +0200 Original-Received: from localhost ([127.0.0.1]:44681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDslO-0002H0-Fn for ged-emacs-devel@m.gmane.org; Tue, 09 Apr 2019 11:34:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDslG-0002Gc-Gs for emacs-devel@gnu.org; Tue, 09 Apr 2019 11:34:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDslF-0006Fc-En for emacs-devel@gnu.org; Tue, 09 Apr 2019 11:34:10 -0400 Original-Received: from [195.159.176.226] (port=55984 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDslF-0006BX-1z for emacs-devel@gnu.org; Tue, 09 Apr 2019 11:34:09 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hDslD-000tDa-8w for emacs-devel@gnu.org; Tue, 09 Apr 2019 17:34:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:HMbkdjBrIfJK2+jlrbYxhI4wlro= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235167 Archived-At: > IWBNI this was also done for proper-list-p: > > (byte-compile '(proper-list-p '(0))) > ;; => (byte-code "\300\301!\207" [proper-list-p (0)] 2) > > Is the following kosher? > @@ -879,7 +879,8 @@ byte-optimize-memq > (put 'symbolp 'byte-optimizer 'byte-optimize-predicate) > (put 'stringp 'byte-optimizer 'byte-optimize-predicate) > (put 'string< 'byte-optimizer 'byte-optimize-predicate) > -(put 'string-lessp 'byte-optimizer 'byte-optimize-predicate) > +(put 'string-lessp 'byte-optimizer 'byte-optimize-predicate) > +(put 'proper-list-p 'byte-optimizer 'byte-optimize-predicate) > > (put 'logand 'byte-optimizer 'byte-optimize-predicate) > (put 'logior 'byte-optimizer 'byte-optimize-predicate) I think this is currently right. > @@ -1160,8 +1161,8 @@ byte-optimize-set > make-list make-string make-symbol marker-buffer max member memq min > minibuffer-selected-window minibuffer-window > mod multibyte-char-to-unibyte next-window nth nthcdr number-to-string > - parse-colon-path plist-get plist-member > - prefix-numeric-value previous-window prin1-to-string propertize > + parse-colon-path plist-get plist-member prefix-numeric-value > + previous-window prin1-to-string proper-list-p propertize > degrees-to-radians > radians-to-degrees rassq rassoc read-from-string regexp-quote > region-beginning region-end reverse round I think it'd be better to add a `side-effect-free` property rather than add to this list. We should be moving away from having this list in byte-opt.el since that info can also be used when byte-opt is not loaded. > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index 8bbe6292d9..0e953dc96b 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -3566,6 +3566,7 @@ byte-defop-compiler-1 > > ;;####(byte-defop-compiler move-to-column 1) > (byte-defop-compiler-1 interactive byte-compile-noop) > +(byte-defop-compiler-1 proper-list-p 1) I don't think this is needed. Stefan