From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master c3e8381: * lisp/gnus/gnus-sum.el: Use lexical-binding Date: Fri, 17 May 2019 12:45:12 -0400 Message-ID: References: <20190515175318.10237.53148@vcs0.savannah.gnu.org> <20190515175319.ACE4B20537@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="171162"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: monnier@iro.umontreal.ca To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 17 18:59:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hRgCx-000iNF-1U for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 18:59:47 +0200 Original-Received: from localhost ([127.0.0.1]:51254 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRgCw-0001zJ-1u for ged-emacs-devel@m.gmane.org; Fri, 17 May 2019 12:59:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRgCA-0001VA-3A for emacs-devel@gnu.org; Fri, 17 May 2019 12:58:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRfyz-0007yp-BO for emacs-devel@gnu.org; Fri, 17 May 2019 12:45:22 -0400 Original-Received: from [195.159.176.226] (port=35594 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRfyz-0007wZ-41 for emacs-devel@gnu.org; Fri, 17 May 2019 12:45:21 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1hRfyx-000RJg-Ci for emacs-devel@gnu.org; Fri, 17 May 2019 18:45:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ Cancel-Lock: sha1:wdlDtSNA1TgaMa4KhEkyyxKgE0o= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236679 Archived-At: > This commit causes problems with the display of thread related fields in > summary lines in the summary buffer. > > `gnus-summary-line-format-alist' is used to expand the summary line > format string. The ?V, ?t and ?e formats expect `thread' to be bound > dynamically. Now that this file uses lexical binding that no longer > works. Indeed, thanks. Does the patch below work for you? > Several entries in the alist also use "(macroexpand (mail-header-..." > which appears to no longer be needed, as the mail header accessors are > now functions not macros. Not sure what's best: get rid of the `macroexpand` calls or replace them with `macroexpand-all`? Stefan