From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 0ad1c0d: * lisp/net/tramp.el (tramp-handle-make-process): Handle shell commands. Date: Sun, 20 Dec 2020 16:29:16 -0500 Message-ID: References: <20201218123338.4927.85373@vcs0.savannah.gnu.org> <20201218123339.A90E820B72@vcs0.savannah.gnu.org> <87czz787dk.fsf@gmx.de> <87y2hv5ch6.fsf@gmx.de> <87tusj58pw.fsf@gmx.de> <87o8io9ulx.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26605"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 20 22:30:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kr6Hl-0006qr-Ng for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Dec 2020 22:30:37 +0100 Original-Received: from localhost ([::1]:57032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kr6Hk-00074W-Qt for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Dec 2020 16:30:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr6Gb-0006Zw-Dq for emacs-devel@gnu.org; Sun, 20 Dec 2020 16:29:25 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kr6GY-0002UG-T5 for emacs-devel@gnu.org; Sun, 20 Dec 2020 16:29:24 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1A8CF100229; Sun, 20 Dec 2020 16:29:21 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 940B71000D1; Sun, 20 Dec 2020 16:29:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1608499759; bh=uVMu6GAPOyGT8IRI/UmiZ+X9DhpgiDOFIBTka509W94=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=UcrCh1+VIhm7u/wkHUBFSMQRn97VnPI6bGT270y9lOm0we7eKhHzgV8HZXYOgDClB b0SHh2Q/FcWWW0KTPn8f8KcsjWrXK5YMwG1TYPrKtL/K+dUWUVWWXPK9QWaEWWBbQj k2HFg7jW467SLqgMn9W+o+3wtTn4Jxz+H00Qo/JDoVcdxMg2vWvRJgcpwHG+ncbVVi fvTw9LTSWazvMP75BHwLQXhs0yyBAQm4HNCd1nukFw+8xnuoXzfZh68gXdJ0YSFOs0 yRPja+bbVQ+QFNG2WhOtsOmcNmE4NImrIMag+FJ/Pll74fBaqKAcM7d/hqAsShQ8h3 T64FNT/yy9K8g== Original-Received: from alfajor (69-165-136-52.dsl.teksavvy.com [69.165.136.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 60BE41201A6; Sun, 20 Dec 2020 16:29:19 -0500 (EST) In-Reply-To: <87o8io9ulx.fsf@gmx.de> (Michael Albinus's message of "Sun, 20 Dec 2020 19:54:02 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261356 Archived-At: >> Concatenating arguments with a " " separator is plain wrong. >> That's why we have >> >> (declare (advertised-calling-convention (name buffer command) "23.1")) >> >> so we can hopefully soon drop support for that concatenation. > > I've dropped this. Thanks. >> So the `command` doesn't need any quoting here: it's >> start-file-process's responsability to make sure it starts a process >> with those 3 strings (shell-file-name as the name of the executable, >> `shell-command-switch` as the first arg and `command` as the second). >> >> In the case of Tramp's implementation of `start-file-process`, you're >> going to run this process by constructing a command to send to the >> remote shell, so you'll indeed need to turn this list of strings >> into a single string and you need to do it by quoting those strings >> using the quoting that corresponds to that of the remote shell (which >> is indeed what `tramp-shell-quote-argument` does, IIUC). >> IOW, I'd expect `start-file-process` to do something like >> >> (mapconcat #'tramp-shell-quote-argument args " ") >> >> to construct the command to send to the remote shell. > > My recent patch (pushed) is along these lines. In > tramp-handle-make-process, but this is just an implementation detail. I'm glad we could find a less hackish solution (tho those levels of quoting are involved, "hackish" is largely unavoidable). Stefan