From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master bacc24b 5/5: Use `lexical-binding` in all the cal-*.el files Date: Thu, 21 Jan 2021 09:56:03 -0500 Message-ID: References: <83eeie75az.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33540"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 21 15:57:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2bPB-0008dK-BW for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Jan 2021 15:57:49 +0100 Original-Received: from localhost ([::1]:57526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2bPA-0006kc-CV for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Jan 2021 09:57:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2bNc-0005v5-AC for emacs-devel@gnu.org; Thu, 21 Jan 2021 09:56:12 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34898) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2bNY-0000Wk-6n; Thu, 21 Jan 2021 09:56:11 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1440C440C8E; Thu, 21 Jan 2021 09:56:06 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B5E2044030E; Thu, 21 Jan 2021 09:56:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611240964; bh=huTrTlowbBKTRAkWzobC3dbM+JnIFjGKw/S3quTv1OI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ew5yYNtXBUn+ksZzyr83K7PEvNtbGls6hIFPmYn915rjiBTVx2AXZkjvwvJtorJpm +3VcE9oG79zG9FCI9r3tN9h1hGC4izUghbRFzpQxUEH3RxnwhamFeEfrRUK8OCIH1F 7z8bWWgoQKcF+KPXOPobQC9uNzodrlTrQldCCtlCzOscACZ7Cv/550junspIo+1+OX oSqVmgqcHZwJRK6KRS2CFK/ApU1goieAckEEmYD2GOHRE97iFWAbuSFxtH0hc4NGKr 7PGtnCamO27yaYSmhqgQndnZPnVIbSgJlAbcaWhQ7783uqbVhKGYWJ00Zgt2pJ1YxW 4xjf8aSazHJPg== Original-Received: from alfajor (unknown [45.72.224.181]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 59B7C1201E0; Thu, 21 Jan 2021 09:56:04 -0500 (EST) In-Reply-To: <83eeie75az.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Jan 2021 16:06:28 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263239 Archived-At: > This causes many warnings like these: > > In diary-chinese-anniversary: > calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic > variable date > calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic > variable date > calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic > variable date > calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic > variable date > calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic > variable date > calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic > variable date > calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic > variable date Yes, I saw that as well, but I haven't yet figured out why. If you do rm lisp/calendar/cal-china.elc make the compilation proceeds without warnings. I'm still tracking this down. Stefan