unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* master bacc24b 5/5: Use `lexical-binding` in all the cal-*.el files
@ 2021-01-21 14:06 Eli Zaretskii
  2021-01-21 14:56 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2021-01-21 14:06 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

This causes many warnings like these:

  In diary-chinese-anniversary:
  calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
      variable date
  calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
      variable date
  calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
      variable date
  calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
      variable date
  calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
      variable date
  calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
      variable date
  calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
      variable date



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: master bacc24b 5/5: Use `lexical-binding` in all the cal-*.el files
  2021-01-21 14:06 master bacc24b 5/5: Use `lexical-binding` in all the cal-*.el files Eli Zaretskii
@ 2021-01-21 14:56 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2021-01-21 14:56 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

> This causes many warnings like these:
>
>   In diary-chinese-anniversary:
>   calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
>       variable date
>   calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
>       variable date
>   calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
>       variable date
>   calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
>       variable date
>   calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
>       variable date
>   calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
>       variable date
>   calendar/cal-china.el:731:60: Warning: Lexical argument shadows the dynamic
>       variable date

Yes, I saw that as well, but I haven't yet figured out why.  If you do

    rm lisp/calendar/cal-china.elc
    make

the compilation proceeds without warnings.  I'm still tracking this down.


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-21 14:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 14:06 master bacc24b 5/5: Use `lexical-binding` in all the cal-*.el files Eli Zaretskii
2021-01-21 14:56 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).