From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 5065698: Move the =?utf-8?B?4oCYZGVjbGFyZeKAmQ==?= form before the interactive spec in 10 functions. Date: Fri, 22 Jan 2021 09:04:44 -0500 Message-ID: References: <20210120191935.5488.54008@vcs0.savannah.gnu.org> <20210120191936.DCB55209AB@vcs0.savannah.gnu.org> <87r1mfl3r5.fsf@gnus.org> <87h7nbs34v.fsf@mail.linkov.net> <87eeifqnve.fsf@mail.linkov.net> <87im7ruu92.fsf@mail.linkov.net> <874kjazlda.fsf@mail.linkov.net> <87v9bp7wft.fsf@mail.linkov.net> <8735yte4oy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36178"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 22 15:08:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2x6h-0009IM-Ue for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jan 2021 15:08:11 +0100 Original-Received: from localhost ([::1]:34536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2x6g-00024f-S0 for ged-emacs-devel@m.gmane-mx.org; Fri, 22 Jan 2021 09:08:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2x3b-0007OM-FL for emacs-devel@gnu.org; Fri, 22 Jan 2021 09:05:00 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2x3X-0003FX-Bx for emacs-devel@gnu.org; Fri, 22 Jan 2021 09:04:58 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A09C880967; Fri, 22 Jan 2021 09:04:53 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EEDB4807F5; Fri, 22 Jan 2021 09:04:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611324284; bh=ks7SY4AvO4I7W2zo4HJYRKK9W4BZtO2hMdOHY9tuqEU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PbsMYewUwkhR0KoJc4hN0Lhmnz6Yo/6vMETYElm20eN23xHy7oe/Bwtm7astZ03tt jqOJaZ/OuCX0o4exSlLFR7yT5GVF3UwL2BoUpV6Jub92E3DlHt5aOc8Nt5mljmRqjn N/YUKqocygPZKtuqg1O5JHOoCSKva8LTw5rkZTm29DvhHuy2sQ7U8nUdLowPR/65Bp +4356ZaBkUfJ1gn0jeJkgpdShDwwNFm7MPvQDk+mtD12M+aUwGpHTVOvarMgnZWsdB VQu2/0Efm6cYVk+mDoktMjT6G1YarAoIcMVjl6P0NWmsuGc49Fy0LJqNODxfHRgmqX OrjVYPIwakzMw== Original-Received: from alfajor (65-110-220-188.cpe.pppoe.ca [65.110.220.188]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A16E31200F4; Fri, 22 Jan 2021 09:04:44 -0500 (EST) In-Reply-To: <8735yte4oy.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 22 Jan 2021 10:50:05 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263275 Archived-At: >>> - (t (message "Warning: Unknown defun property `%S' in %S" >>> - (car x) name))))) >>> + (t (message "%S:%d:Warning: Unknown defun property `%S'" >>> + name (count-lines (point-min) (point)) >>> + (car x)))))) >> I think `count-lines` is a problem because we don't know in which buffer >> we are when this is executed. > The GNU Coding Standard format requires a line number between colons, > so maybe count-lines would give some plausible number in most cases. But 0 would work as well for that purpose. >> Another approach could be to use something like >> `macroexp--warn-and-return`. > `macroexp--warn-and-return` uses `load-file-name` that is nil here. Not necessarily, no: when compiling, it will let bytecomp.el emit the warning which gives proper file and line numbers. Do we care about the format used when we're not compiling? [ This is not a rethorical question. ] > I tried it, but it has no effect. > > (let ((warnfun (lambda () > (message "Warning: Unknown defun property `%S' in %S" > (car x) name)))) > `(progn > (macroexp--funcall-if-compiled ',warnfun))) How did you try it? Stefan