From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Little improvements on pulse.el Date: Thu, 11 Mar 2021 10:35:57 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5096"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Gabriel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 11 16:59:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKNil-0001Cy-JA for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 16:59:31 +0100 Original-Received: from localhost ([::1]:41000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKNik-0006Qz-IJ for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 10:59:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKNM5-0000uJ-Hs for emacs-devel@gnu.org; Thu, 11 Mar 2021 10:36:05 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKNM2-0004o6-HX for emacs-devel@gnu.org; Thu, 11 Mar 2021 10:36:04 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1852F10023D; Thu, 11 Mar 2021 10:36:01 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A2C571000CF; Thu, 11 Mar 2021 10:35:59 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1615476959; bh=j2zRMsuDMgJPSXWKBN9kn6aGn7Rif6zFNOkxuw+Oql0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XJ4Xc4loDrFYpiIdrccLsjpcNmfnX1l9CZmx/xFuz+A4bSUBhzHa+M0IAXXesIwlM UvrDQpBXuVL8wM5A/yMdKpNigk3D3wBV0sCZM8VbRtzEvdao8VH4E7d2abeJo8hX8s mdPz0p63kApl49QevKuyIaG8iH2Zdcy5gz59FRK8VY3z9vI4lwi7jZhZcRBXY4vRFl bXE7rQ4O2JK+YBdDNALoXWIAg7IG/NfChUKaajAd24UtLg3I9RrmmSPrxy6jzftwEJ 24hik9ZMF+OB/ManbeQUetpYo9LUdl0C1LLiPh3PuXN/ZRSLSvwcPGL1ulWpGHWZoz 45RPfGAtzej2A== Original-Received: from alfajor (unknown [216.154.43.249]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0945E1201A2; Thu, 11 Mar 2021 10:35:58 -0500 (EST) In-Reply-To: (Gabriel's message of "Wed, 10 Mar 2021 02:39:56 -0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266328 Archived-At: > 2. The name and the docstring mention the use with hooks, but would be Indeed, and that is generally a bad idea: docstring should aim to describe what the function does rather than when/where it's expected to be used [insert general disclaimer that all generalizations are bad]. > 5. The code on 'pulse-lighten-highlight' can be significantly improved > by replacing 'pulse-int-to-hex' and 'pulse-color-values-to-hex' with > 'color-gradient' from color.el. I think pulse.el was written before color.el was added to Emacs, so I wouldn't be surprised that there's room for simplifying and improving the code. Stefan