From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Gabriel <gabriel376@hotmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Little improvements on pulse.el
Date: Thu, 11 Mar 2021 10:35:57 -0500 [thread overview]
Message-ID: <jwv35x1ogh3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CH2PR01MB5879637707F4A54A1418825F8B919@CH2PR01MB5879.prod.exchangelabs.com> (Gabriel's message of "Wed, 10 Mar 2021 02:39:56 -0300")
> 2. The name and the docstring mention the use with hooks, but would be
Indeed, and that is generally a bad idea: docstring should aim to
describe what the function does rather than when/where it's expected to
be used [insert general disclaimer that all generalizations are bad].
> 5. The code on 'pulse-lighten-highlight' can be significantly improved
> by replacing 'pulse-int-to-hex' and 'pulse-color-values-to-hex' with
> 'color-gradient' from color.el.
I think pulse.el was written before color.el was added to Emacs, so
I wouldn't be surprised that there's room for simplifying and improving
the code.
Stefan
prev parent reply other threads:[~2021-03-11 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 5:39 Little improvements on pulse.el Gabriel
2021-03-10 12:13 ` Eli Zaretskii
2021-03-10 13:41 ` Stefan Kangas
2021-03-10 17:18 ` Juri Linkov
2021-03-10 18:51 ` Juri Linkov
2021-03-10 19:11 ` Eli Zaretskii
2021-03-11 23:42 ` Gabriel
2021-03-12 7:29 ` Eli Zaretskii
2021-03-10 18:59 ` Juri Linkov
2021-03-11 15:35 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv35x1ogh3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).