From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@linkov.net>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: New Context Menu and mouse-1
Date: Mon, 30 Aug 2021 08:54:30 -0400 [thread overview]
Message-ID: <jwv35qrf62q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87y28j1lja.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 30 Aug 2021 10:22:01 +0300")
Juri Linkov [2021-08-30 10:22:01] wrote:
>>> BTW, maybe another way to look at the problem is to say that
>>> invoking the context-menu should not exit the transient map (but this
>>> may come with its own set of problems, of course).
>>
>> + (when (memq (car-safe last-input-event) '(mouse-1 drag-mouse-1))
>> + (deactivate-mark)
>> + (pop-mark))))))
>
> Or rather
>
> + (unless (and context-menu-mode
> + (eq (car-safe (aref (this-command-keys-vector) 0))
> + 'down-mouse-3))
> + (deactivate-mark)
> + (pop-mark))))))
This looks "honest and safe". If you can add a comment explaining why
we have this ad-hoc hack there, then I think it's quite acceptable
(given that we're unable to figure out what is The Right Way).
Stefan
prev parent reply other threads:[~2021-08-30 12:54 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210818120834.i3orh535tb2enpos.ref@Ergus>
2021-08-18 12:08 ` New Context Menu Ergus
2021-08-18 12:26 ` Eli Zaretskii
2021-08-18 12:43 ` Ergus
2021-08-18 13:30 ` Eli Zaretskii
2021-08-18 17:17 ` Ergus
2021-08-18 17:21 ` Eli Zaretskii
2021-08-18 17:32 ` Ergus
2021-08-18 16:50 ` Eli Zaretskii
2021-08-18 18:10 ` Ergus
2021-08-18 18:17 ` Eli Zaretskii
2021-08-18 19:23 ` Ergus
2021-08-18 19:28 ` Eli Zaretskii
2021-08-18 19:53 ` Ergus
2021-08-19 6:31 ` Eli Zaretskii
2021-08-19 7:07 ` Juri Linkov
2021-08-18 19:34 ` Eli Zaretskii
2021-08-18 18:58 ` Juri Linkov
2021-08-18 19:12 ` Eli Zaretskii
2021-08-19 7:05 ` Juri Linkov
2021-08-19 7:51 ` Eli Zaretskii
2021-08-20 7:13 ` Juri Linkov
2021-08-20 11:26 ` Eli Zaretskii
2021-08-20 11:41 ` Eli Zaretskii
2021-08-20 16:44 ` Juri Linkov
2021-08-20 12:26 ` Ergus
2021-08-20 12:36 ` Eli Zaretskii
2021-08-20 12:59 ` Ergus
2021-08-20 13:03 ` Ergus
2021-08-20 13:34 ` Eli Zaretskii
2021-08-20 17:36 ` Ergus
2021-08-20 18:05 ` Eli Zaretskii
2021-08-20 18:08 ` Ergus
2021-08-20 19:07 ` Eli Zaretskii
2021-08-21 6:20 ` Ergus
2021-08-21 6:53 ` Eli Zaretskii
2021-08-21 15:04 ` Ergus
2021-08-20 18:15 ` Ergus
2021-08-20 23:15 ` Michael Welsh Duggan
2021-08-18 14:04 ` Jean-Christophe Helary
2021-08-18 16:38 ` Iñigo Serna
2021-08-19 0:38 ` Jean-Christophe Helary
2021-08-19 7:08 ` Juri Linkov
2021-08-19 14:22 ` Jean-Christophe Helary
2021-08-19 7:01 ` Juri Linkov
2021-08-19 8:03 ` Eli Zaretskii
2021-08-19 14:11 ` Ergus
2021-08-19 15:48 ` Eli Zaretskii
2021-08-19 16:34 ` Yuri Khan
2021-08-20 7:14 ` Juri Linkov
2021-08-20 11:29 ` Eli Zaretskii
2021-08-20 16:49 ` Juri Linkov
2021-08-20 18:01 ` Eli Zaretskii
2021-08-23 7:33 ` Juri Linkov
2021-08-23 11:36 ` Eli Zaretskii
2021-08-23 16:04 ` Juri Linkov
2021-08-23 16:35 ` Eli Zaretskii
2021-08-23 17:42 ` Juri Linkov
2021-08-23 18:02 ` Ergus
2021-08-24 6:35 ` Juri Linkov
2021-08-24 8:00 ` Ergus
2021-08-24 11:44 ` Yuri Khan
2021-08-24 16:05 ` Ergus
2021-08-24 19:41 ` Yuri Khan
2021-08-24 20:48 ` Ergus
2021-08-19 13:57 ` Ergus
2021-08-20 7:24 ` Juri Linkov
2021-08-20 12:21 ` Ergus
2021-08-20 16:41 ` Juri Linkov
2021-08-21 4:33 ` Ergus via Emacs development discussions.
2021-08-22 8:56 ` Juri Linkov
2021-08-27 6:21 ` New Context Menu and mouse-1 Juri Linkov
2021-08-27 6:55 ` Eli Zaretskii
2021-08-27 17:03 ` Juri Linkov
2021-08-27 22:01 ` Stefan Monnier
2021-08-28 18:52 ` Juri Linkov
2021-08-29 16:53 ` Juri Linkov
2021-08-30 7:22 ` Juri Linkov
2021-08-30 12:54 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv35qrf62q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).