From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f515d658e5 1/2: Don't quote numbers in byte-run--set-* Date: Sun, 19 Jun 2022 18:24:02 -0400 Message-ID: References: <165548588979.10920.4402229762078749924@vcs2.savannah.gnu.org> <20220617171130.8EDECC01685@vcs2.savannah.gnu.org> <878rpv40yk.fsf@gnus.org> <875yky2omz.fsf@gnus.org> <871qvkzz6x.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13506"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 20 00:24:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o33Lf-0003MP-NN for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Jun 2022 00:24:51 +0200 Original-Received: from localhost ([::1]:43140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o33Le-0002UL-OF for ged-emacs-devel@m.gmane-mx.org; Sun, 19 Jun 2022 18:24:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o33L2-0001oF-7Z for emacs-devel@gnu.org; Sun, 19 Jun 2022 18:24:12 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39123) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o33Kz-000259-6F for emacs-devel@gnu.org; Sun, 19 Jun 2022 18:24:10 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4C5B84400EE; Sun, 19 Jun 2022 18:24:07 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 305C5440B1D; Sun, 19 Jun 2022 18:24:06 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1655677446; bh=1UpK6rrtxFHpAvllWeQut/3ES5Cy6GjoeKRvxTbbdSo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=KZ0CWhHc9v+KQR+PSKSK8ZWNgYpr9FwLKCofdBY/aWMFiKd69JfsSo/EgYU4XvPQQ 336pPA8fdOj/sZIMGIwx2TjI0DzQF+XG66KrhN6tSi/T+IsOo39OqEgpptZKfLq+ej SUv+8fOcmQlanrBU12jCnh4YkdwEp1UguC6k+y/tGzCW/1WpaUQmi7bg5It25FbirR wSQY5hI2vEkdMb4kaoDU4PTUHhAzh/LEJqQHbRhlc8T40KUTIJ1/uS6gqnEA01uMLm +DC5UAYSMl+W57k8ySrrhjEV323i84vXGdcq4goFbo2brQbCLhUFeZcfeXZZt1D5GV swx16CwGdrQLA== Original-Received: from alfajor (196.214.25.93.rev.sfr.net [93.25.214.196]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6A8A0120473; Sun, 19 Jun 2022 18:24:05 -0400 (EDT) In-Reply-To: <871qvkzz6x.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 19 Jun 2022 13:10:14 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291440 Archived-At: >> FWIW, the goal wasn't to avoid an `if` but to allow an >> arbitrary expression. But I agree the gain is minuscule. > Perhaps we should have a quote-if-not-self-quoting function for these > things? We do, it's called `macroexp-quote`, but that does the same as your `if`, i.e. it does not change the semantics but just optimizes away the `quote` when it doesn't make a difference. Also we probably wouldn't want to use it here because `macroexp-quote` is defined much too late in the bootstrap (or we'd have to move it first). My proposal was to change the semantics, rather than to "avoid if". According to it, (declare (doc-string (foo bar))) would actually set `doc-string-elt` to the return value of calling (foo bar) rather than setting it to the list `(foo bar)`. Stefan