From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 40c0124816: Minor improvements to precision scroll interpolation Date: Sat, 30 Jul 2022 03:27:44 -0400 Message-ID: References: <8335ej6t0v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18167"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Po Lu , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 30 09:29:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oHgur-0004WY-4Q for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 09:29:41 +0200 Original-Received: from localhost ([::1]:53600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oHgup-00064d-Ku for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Jul 2022 03:29:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHgt7-0004dB-5O for emacs-devel@gnu.org; Sat, 30 Jul 2022 03:27:53 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:65265) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oHgt4-0000mI-KC; Sat, 30 Jul 2022 03:27:52 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AA48644078E; Sat, 30 Jul 2022 03:27:48 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7847E4400B6; Sat, 30 Jul 2022 03:27:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1659166067; bh=cKsp+VOnK1gGbnjNv5LPiIQ3VI2speo8yt3k5vlb3o4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kc14Fm49AdtarI9AHYvcMlzxI2PsTUZbvmEDlpWqAKfjc+1oiuGPNVZhcdk1JZcQC 56n24DzaJMtT/eOxfQMjBIbB+8RimgnQson+2XjC5QSSRvDpOfNhIlyQ7bPPrpnZV9 GDFxJxquTwGgraARNN8CwPtVyXbuuorcgn0R6TEzXi7XxE6RTIT8IeeE6hFProiNT6 6QQObuPOEyX03rOJ+zKVfJu2xycwcdEIAnkZFquLbGNcgoTgkQ5jduGxGxvspnACoo f+a9v9ET5rZG4+BPcGDsWlICMqHtn86t2YjsdG96tFt5YDMcynFx9rwWEFHBtUgcNh 48llZMRfTQL8A== Original-Received: from milanesa (dyn.144-85-173-129.dsl.vtx.ch [144.85.173.129]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A38F8120329; Sat, 30 Jul 2022 03:27:46 -0400 (EDT) In-Reply-To: <8335ej6t0v.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Jul 2022 08:58:40 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292855 Archived-At: >> --- a/lisp/pixel-scroll.el >> +++ b/lisp/pixel-scroll.el >> @@ -759,6 +759,9 @@ It is a vector of the form [ VELOCITY TIME SIGN ]." >> (interactive "e") >> (when pixel-scroll-precision-use-momentum >> (let ((window (mwheel-event-window event)) >> + ;; The animations are smoother if the GC threshold is >> + ;; reduced for the duration of the animation. >> + (gc-cons-threshold (* gc-cons-threshold 3)) >> (state nil)) > > I don't think it is safe to multiply gc-cons-threshold without some > kind of limitation from above: the user or some Lisp program could > have increased the threshold already to a large value. And I also suspect the above won't be "sufficient" when the heap is large, because in that case `gc-cons-threshold` doesn't have any effect any more and it's `gc-cons-percentage` that matters instead. Maybe binding `gc-cons-percentage` to something like the 1.0 value we now use in batch mode (or rather to (max 1.0 gc-cons-percentage)) would be a better option. Stefan