From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 50020d026c: Untabify rcirc.el Date: Wed, 07 Sep 2022 08:54:59 -0400 Message-ID: References: <166254232836.24759.17163698181249816742@vcs2.savannah.gnu.org> <20220907091848.B4E13C04F04@vcs2.savannah.gnu.org> <878rmvphp9.fsf@gnus.org> <87tu5jmnvb.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2176"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Sep 07 14:57:27 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVucQ-0000O7-QK for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 14:57:26 +0200 Original-Received: from localhost ([::1]:41846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVucP-00054E-8L for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Sep 2022 08:57:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVuaA-0003Ix-Jc for emacs-devel@gnu.org; Wed, 07 Sep 2022 08:55:06 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:56894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVua7-0008H1-Ut for emacs-devel@gnu.org; Wed, 07 Sep 2022 08:55:05 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C4EA644102E; Wed, 7 Sep 2022 08:55:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 85628441016; Wed, 7 Sep 2022 08:55:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662555300; bh=/A/chp5lMvpSObM8g8FRdm3qM59Ac+5KkJ8q2gFjZhg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JTFqzB1tKTPm4hkz7rzd/b263iwjPr+k/B4WWfbACp8eRA/Og4SHUHfNKbdINECQv yuYzFkkNgFy6QTZLgujDPSH1iru6tcSUlC2waXp3iY5lsfL4amhXOk85NkiNShIRFh VhEj4AiVT1n5dlw4dxOn5EaN5XsgaUjQYX4301zByfTb/YV4OqxwWcvMojLn8xwk8a KQa5eL/cD2IT4InXg+FINhLLaxL0pIOfbpqCbzdYOKya0Q5kA/hqcwMz5ML4zloYdu bL78WBfhOT32tIkq+vNlf9wXsxAXnSqiWt5K3ETRl6Qyal/9i6auB2AJi/N1h/KxVL uYgP2Qmt4RIqw== Original-Received: from pastel (unknown [157.52.9.190]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 56ABB1205FB; Wed, 7 Sep 2022 08:55:00 -0400 (EDT) In-Reply-To: <87tu5jmnvb.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 07 Sep 2022 11:21:12 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294831 Archived-At: > My apologies, I didn't know that there was a general rule like this. > The last few times I had been working on rcirc I always ran into issues > with whitespaces whenever indenting a function. Every patch had > unrelated whitespace changes that had to be reverted to that the > historical record isn't polluted. Whitespace changes are "by definition" gratuitous. We don't disallow them, but they should be limited to the lines that are changed for other reasons as well. [ Note also that there are degrees: e.g. reindentation is not 100% gratuitous, contrary to tabify/untabify. ] > On a related note, I believe there has been a need to reorder rcirc to > make it easier to follow along for a while. But it goes without saying > that that would break the git history far more than this change. This is yet elsewhere on the scale of "gratuitous", so we also prefer to refrain from doing so, but sometimes it's justified (usually together with a string of other, more substantial, changes). Stefan "guilty of many non-whitespace but still gratuitous changes"