From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: scratch/backend-completion aaaa016056 2/2: Speed it up Date: Sat, 03 Dec 2022 09:10:41 -0500 Message-ID: References: <167007345844.23701.8454474119701440468@vcs2.savannah.gnu.org> <20221203131739.3FCF9C004BE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19662"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 03 15:11:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1TEd-0004u8-LD for ged-emacs-devel@m.gmane-mx.org; Sat, 03 Dec 2022 15:11:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1TE8-0003nu-EF; Sat, 03 Dec 2022 09:10:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1TE6-0003nQ-Im for emacs-devel@gnu.org; Sat, 03 Dec 2022 09:10:46 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1TE5-00062N-1W for emacs-devel@gnu.org; Sat, 03 Dec 2022 09:10:46 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7D7B8440F4F; Sat, 3 Dec 2022 09:10:43 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F14484409DF; Sat, 3 Dec 2022 09:10:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1670076642; bh=4J1rSMSMfe2nNXRhUv0YjcBnQw8StE11tDTFrjwzG84=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DFdvs64QjBGot9iEQ4Nm53nvKS92dR0V1ui5dXK6gg0QstaqVn/JxzXcRuzSEvRZH FK97TgaX+bgklDKPNJkJyuEHkQJP7D6pft+xVX++VEURjAlKMuSbHtbIBpiT8xc8uR CU2m9YIxfjXEUUHfyUCKyd0pnelMOkXbMp77iEGBDnFs/H3IC7LAtKvaE6W7r5RmTH AceStukXbRH1rl9rGlHuFDxYM1obfcS70lMsvq0NL1bcFkg7fMRJlECsS30oDuIKj8 KROt2wXYuoVdUS+FkH9K2dM7ZhWjt1fq3BV4FWbhLUnXlKTzxArMTdx3Gc3O3BJ5Ad 8JRGvNxDqaBaA== Original-Received: from pastel (unknown [45.72.193.52]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CE6751208FD; Sat, 3 Dec 2022 09:10:41 -0500 (EST) In-Reply-To: <20221203131739.3FCF9C004BE@vcs2.savannah.gnu.org> (=?windows-1252?Q?=22Jo=E3o=09T=E1vora=22's?= message of "Sat, 3 Dec 2022 08:17:39 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300870 Archived-At: > diff --git a/lisp/external-completion.el b/lisp/external-completion.el > index da3a986b8c..25e94e540b 100644 > --- a/lisp/external-completion.el > +++ b/lisp/external-completion.el > @@ -104,8 +104,10 @@ taking a (STRING POINT) as arguments. The default is to set to > `(external-completion-allc . ,(if pred (seq-filter pred all) all)))) > (`(boundaries . ,_) nil) > (_ > - (let ((all (funcall lookup string (length string)))) > - (complete-with-action action all string pred)))))) > + ;; FIXME: Stefan had a call to `lookup' and > + ;; `complete-with-action' again here, but that just seems to > + ;; slow down things for no good reason, so I took it out. > + )))) The code was definitely needed for some cases like `try-completion` and `all-completions` (e.g. to make sure we only return completion of the `string` *prefix* as callers of those functions expect and to make sure we obey `pred`). But I'm surprised it made things slow: this code should only be involved when the user choose some *other* completion style, so could you check which method of the completion table was invoked? Maybe we should only use that code when `action` is one of `t` or `nil`? Stefan