From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 02e046566e 3/3: Set beginning/end-of-defun-function in treesit-major-mode-setup Date: Thu, 22 Dec 2022 09:59:50 -0500 Message-ID: References: <167169878178.1257.12592279240667535659@vcs2.savannah.gnu.org> <20221222084623.4FFA8C0061B@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34967"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Yuan Fu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 22 16:00:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p8N3i-0008vt-Qi for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Dec 2022 16:00:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p8N3A-0007gC-6c; Thu, 22 Dec 2022 10:00:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8N37-0007fx-RE for emacs-devel@gnu.org; Thu, 22 Dec 2022 09:59:58 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8N36-0004Pu-C9 for emacs-devel@gnu.org; Thu, 22 Dec 2022 09:59:57 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DEF9280608; Thu, 22 Dec 2022 09:59:54 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 1703F8058E; Thu, 22 Dec 2022 09:59:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1671721193; bh=TCRnbOfMOHBRX9RfVrWkeBZiSvuR/eJPo7UzTWhL4Ks=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VfqcvRfjOFnANkBRpw8wcHzMGe89jYvbLOAzOWbbdGwNazQLaZmfhTyJjzUcYRdBo DW++CFfrkz6XM+2SxGMtSdYJe9jot/ggRGCqAbYVH6XVEPg62pzrSOj52NAOdcy8+y MH3RVDlO2gz6jANfDavPT1QlDuIJo7zSeR6Op5xEB//xWmiCcxyELb+TtW2Xh1vuNK oRn0FWgTAXcQOSz+Zs8pTn5OKX+QXFP10LeaKMqXKx/6cDrkVNaf4xDE9XFHteq4SK mkoU94t0pLzNnGbS+/KA1rZamzotqMMSNGFiKVzNLrvoF49zoR3n+T1n0HY7UE/RYN v0HKYm4BSYWvg== Original-Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CB36D12305E; Thu, 22 Dec 2022 09:59:52 -0500 (EST) In-Reply-To: <20221222084623.4FFA8C0061B@vcs2.savannah.gnu.org> (Yuan Fu's message of "Thu, 22 Dec 2022 03:46:23 -0500 (EST)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301789 Archived-At: > + ;; `end-of-defun' will not work completely correctly in nested > + ;; defuns due to its implementation. However, many lisp programs > + ;; use `beginning/end-of-defun', so we should still set > + ;; `beginning/end-of-defun-function' so they still mostly work. > + ;; This is also what `cc-mode' does: rebind user commands and set > + ;; the variables. In future we should update `end-of-defun' to > + ;; work with nested defuns. > + (setq-local beginning-of-defun-function #'treesit-beginning-of-defun) > + (setq-local end-of-defun-function #'treesit-end-of-defun))) Is there a bug report for that? Stefan