From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 5a125fb5a97 1/2: Update to Org 9.7.3 Date: Tue, 11 Jun 2024 09:16:17 -0400 Message-ID: References: <171796793548.23337.12512115872160390161@vcs2.savannah.gnu.org> <20240609211858.A2C31C1F9FB@vcs2.savannah.gnu.org> <87a5jtd403.fsf@yahoo.com> <87h6e1lhtd.fsf@kyleam.com> <868qzd9hjg.fsf@gnu.org> <871q53u75e.fsf@localhost> <8634pj7jni.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13535"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Ihor Radchenko , kyle@kyleam.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 11 15:17:07 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sH1N3-0003Gj-BD for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Jun 2024 15:17:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sH1MR-0001PF-PH; Tue, 11 Jun 2024 09:16:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH1MO-0001O2-16 for emacs-devel@gnu.org; Tue, 11 Jun 2024 09:16:26 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sH1MM-0000gO-Cm; Tue, 11 Jun 2024 09:16:23 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0E496442549; Tue, 11 Jun 2024 09:16:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1718111778; bh=brvBMhFnS51PWPE9+S8Izm5vQBclFW8pyOpLhDNzD6o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=j9VP0LGbOvQGLLZBIE1TtT1KfcYsE7pN1eX0OAtGZIXEFYSOXFu/g3SNAca3dF7/r ibCSU1pxEscbhMzPbU/NPytk5L2v4JPUE2OIXmxGysLZTqn4N1St4uCY8aQj7E6q7M aIbcvrZ2gfuy8n/GtQgs84ZyiToKZw664O6iqygAzj8ionSpOIeU8Gx8B9OY2Ty5ed vn32KUq6Cql5QGr4QBQWXxv6nEfG4136PM6EGBsNQK52uGNyqvVl/rmgXgzHPeLUWw Hdx6mVfihelhJ+iFCaGTkkeEBGHnew+zP08eg2m12BR0qKoCM+g5LIHFqJC+O4Od/s qj6PUzDOpL/2A== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C6A4644254F; Tue, 11 Jun 2024 09:16:18 -0400 (EDT) Original-Received: from pastel (unknown [24.140.236.196]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 96363120434; Tue, 11 Jun 2024 09:16:18 -0400 (EDT) In-Reply-To: <8634pj7jni.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Jun 2024 15:23:29 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319975 Archived-At: >> Note that org-num.el where `org-num-skip-tags' is defined does have >> (require 'cl-lib). >> >> IMHO, there is some problem either with loaddefs generation or with the >> fact that loaddefs file is compiled at all. Code that's in an ;;;###autoload cookie is copied verbatim to the loaddefs file, so it cannot assume that all the earlier code in the file (e.g. the `(require 'cl)` at the beginning of the file) has been executed. > No, the problem is that this variable uses cl-lib stuff for safep > functions. IMO, this is not a good idea, and the above situation is > precisely the evidence for that. In theory, `org-loaddefs.el` could be arranged to require `cl-lib` (we don't want that in `loaddefs.el` but it'd be OK for `org-loaddefs.el`). In practice, the generation of `org-loaddefs.el` currently doesn't offer an easy way to insert some ad-hoc code like `(require 'cl-lib)` at the beginning. We should fix that because it's a relatively common need (especially since the relative ordering of elements from different files is not guaranteed). > Stefan, WDYT about this issue? While you're at it, please don't autoload the vars: autoload only the safety declaration. Stefan