Re: master 5a125fb5a97 1/2: Update to Org 9.7.3

[Stefan Monnier <monnier@iro.umontreal.ca>]

>> Note that org-num.el where `org-num-skip-tags' is defined does have
>> (require 'cl-lib).
>>
>> IMHO, there is some problem either with loaddefs generation or with the
>> fact that loaddefs file is compiled at all.

Code that's in an ;;;###autoload cookie is copied verbatim to the
loaddefs file, so it cannot assume that all the earlier code in the file
(e.g. the `(require 'cl)` at the beginning of the file) has been executed.

> No, the problem is that this variable uses cl-lib stuff for safep
> functions.  IMO, this is not a good idea, and the above situation is
> precisely the evidence for that.

In theory, `org-loaddefs.el` could be arranged to require `cl-lib` (we
don't want that in `loaddefs.el` but it'd be OK for `org-loaddefs.el`).
In practice, the generation of `org-loaddefs.el` currently doesn't offer
an easy way to insert some ad-hoc code like `(require 'cl-lib)` at
the beginning.  We should fix that because it's a relatively common need
(especially since the relative ordering of elements from different
files is not guaranteed).

> Stefan, WDYT about this issue?

While you're at it, please don't autoload the vars:
autoload only the safety declaration.


        Stefan