From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [patch] add interactive browse of revisions from vc *Annotate* buffers Date: 21 Jan 2004 09:15:10 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <1073937837.2822.180.camel@localhost> <1074519239.10692.24.camel@localhost> <87u12rbrlf.fsf@emptyhost.emptydomain.de> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1074694980 19921 80.91.224.253 (21 Jan 2004 14:23:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 21 Jan 2004 14:23:00 +0000 (UTC) Cc: brutt+news@bloomington.in.us, kai@emptydomain.de, rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Jan 21 15:22:54 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AjJFu-0008Gr-00 for ; Wed, 21 Jan 2004 15:22:54 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AjJFu-0007gF-00 for ; Wed, 21 Jan 2004 15:22:54 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AjJAU-00076U-PJ for emacs-devel@quimby.gnus.org; Wed, 21 Jan 2004 09:17:18 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AjJA6-00075s-H7 for emacs-devel@gnu.org; Wed, 21 Jan 2004 09:16:54 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AjJ9a-000739-F6 for emacs-devel@gnu.org; Wed, 21 Jan 2004 09:16:53 -0500 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AjJ8a-0006y8-F4; Wed, 21 Jan 2004 09:15:20 -0500 Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 1DAD220FB4; Wed, 21 Jan 2004 09:15:11 -0500 (EST) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id 921C18C6F3; Wed, 21 Jan 2004 09:15:10 -0500 (EST) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: Original-Lines: 14 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=0, requis 5) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19402 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19402 > (defun line-at-pos (&optional pos) > "Return buffer line number and narrowed line number at position POS. > If POS is nil, use current buffer location. > Return value is a cons (line-number . narrowed-line-number)." I suggest to only return narrowed-line-number (i.e. ignore narrowing). After all, most/all functions are expected to ignore narrowing unless they specifically need to know about it. `what-line' can still make use of such a function by doing the widening itself like it used to (and use the same optimization you suggested). Stefan