From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vc.el no longer recognizes files in an arch working directory Date: Fri, 25 May 2007 10:47:31 -0400 Message-ID: References: <87zm3t362q.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1180104478 22225 80.91.229.12 (25 May 2007 14:47:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 25 May 2007 14:47:58 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org To: Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 25 16:47:55 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hrb54-0001KF-JW for ged-emacs-devel@m.gmane.org; Fri, 25 May 2007 16:47:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hrb54-0003VB-1X for ged-emacs-devel@m.gmane.org; Fri, 25 May 2007 10:47:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hrb4y-0003PI-LT for emacs-devel@gnu.org; Fri, 25 May 2007 10:47:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hrb4x-0003Og-W7 for emacs-devel@gnu.org; Fri, 25 May 2007 10:47:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hrb4x-0003Od-Sx for emacs-devel@gnu.org; Fri, 25 May 2007 10:47:43 -0400 Original-Received: from 4.red-83-41-5.dynamicip.rima-tde.net ([83.41.5.4] helo=alfajor.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hrb4v-0000hl-Ru; Fri, 25 May 2007 10:47:42 -0400 Original-Received: by alfajor.home (Postfix, from userid 20848) id 888AA1C150; Fri, 25 May 2007 10:47:31 -0400 (EDT) In-Reply-To: (Miles Bader's message of "Fri\, 25 May 2007 13\:37\:03 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71804 Archived-At: > ... and the following patch seems to fix it: > --- orig/lisp/vc-hooks.el > +++ mod/lisp/vc-hooks.el > @@ -325,7 +325,7 @@ > ;; to another user. This should save us from looking in > ;; things like /net and /afs. This assumes that all the > ;; files inside a project belong to the same user. > - (not (equal user (file-attributes file))) > + (not (equal user (nth 2 (file-attributes file)))) > (string-match vc-ignore-dir-regexp file))) > (if (file-exists-p (expand-file-name witness file)) > (setq root file) > So I'm going to commit this on the branch/trunk. Oops, thanks. > [Geez, people, please test stuff you commit on the release branch!] Sorry 'bout the typo introduce when copy&pasting between the tested code and the installed code. But note that I'm surprised to see this code on the release branch. I never intended for it to go there, never committed there AFAIK and when Richard asked me to install it on the release branch I explicitly said I was not confortable doing it. Looking at the CVS log I see: revision 1.182.2.2 date: 2007-05-17 03:38:11 -0400; author: gm; state: Exp; lines: +8 -1; commitid: wzJ1cmOAuE56Mfis; Sync change from trunk at request of rms in FOR-RELEASE: Stefan Monnier (vc-find-root): Stop searching when the user changes. So it looks like it was Richard's decision. Stefan