* ChangeLog removal
@ 2008-05-01 15:19 Stefan Monnier
2008-05-01 17:46 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2008-05-01 15:19 UTC (permalink / raw)
To: Andreas Schwab; +Cc: emacs-devel
When undoing someone's commit, never remove the changelog entry.
Instead, add another entry saying that you reverted a change.
This is in reference to the attached patch.
Stefan
revision 1.13572
date: 2008-04-27 05:46:57 -0400; author: schwab; state: Exp; lines: +0 -2; commitid: J0UjWj30wxmGmJ0t;
Unbreak bootstrap.
----------------------------
Index: lisp/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.13571
retrieving revision 1.13572
diff -u -r1.13571 -r1.13572
--- lisp/ChangeLog 27 Apr 2008 09:30:36 -0000 1.13571
+++ lisp/ChangeLog 27 Apr 2008 09:46:57 -0000 1.13572
@@ -280,8 +280,6 @@
* cus-start.el: Remove insert-default-directory and
read-file-name-completion-ignore-case.
- * Makefile.in (emacs-deps): Leave it empty.
-
2008-04-23 Magnus Henoch <mange@freemail.hu>
* tar-mode.el (tar-untar-buffer): If the entry has directory
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ChangeLog removal
2008-05-01 15:19 ChangeLog removal Stefan Monnier
@ 2008-05-01 17:46 ` Glenn Morris
2008-05-01 19:42 ` Jason Rumney
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2008-05-01 17:46 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Andreas Schwab, emacs-devel
Stefan Monnier wrote:
> When undoing someone's commit, never remove the changelog entry.
> Instead, add another entry saying that you reverted a change.
(Genuine question, not an attempt to be difficult:)
If I make a change, then very soon after (within a few hours,
definitely the same day) realize I need to revert it, I tend to delete
the ChangeLog entry rather than have two. This is because I don't see
the point in cluttering up the ChangeLog with things that only existed
for a few hours.
Would you prefer two entries in this case? That's fine by me, just
want to clarify the policy...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ChangeLog removal
2008-05-01 17:46 ` Glenn Morris
@ 2008-05-01 19:42 ` Jason Rumney
2008-05-02 14:43 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Jason Rumney @ 2008-05-01 19:42 UTC (permalink / raw)
To: Glenn Morris; +Cc: Andreas Schwab, Stefan Monnier, emacs-devel
Glenn Morris wrote:
> (Genuine question, not an attempt to be difficult:)
>
> If I make a change, then very soon after (within a few hours,
> definitely the same day) realize I need to revert it, I tend to delete
> the ChangeLog entry rather than have two. This is because I don't see
> the point in cluttering up the ChangeLog with things that only existed
> for a few hours.
>
I do the same FWIW. But only when it is my own change, and only when
reverting the same day.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ChangeLog removal
2008-05-01 19:42 ` Jason Rumney
@ 2008-05-02 14:43 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2008-05-02 14:43 UTC (permalink / raw)
To: Jason Rumney; +Cc: Glenn Morris, emacs-devel, Andreas Schwab
>> (Genuine question, not an attempt to be difficult:)
>>
>> If I make a change, then very soon after (within a few hours,
>> definitely the same day) realize I need to revert it, I tend to delete
>> the ChangeLog entry rather than have two. This is because I don't see
>> the point in cluttering up the ChangeLog with things that only existed
>> for a few hours.
> I do the same FWIW. But only when it is my own change, and only when
> reverting the same day.
Yes, I think this is OK.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-02 14:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-01 15:19 ChangeLog removal Stefan Monnier
2008-05-01 17:46 ` Glenn Morris
2008-05-01 19:42 ` Jason Rumney
2008-05-02 14:43 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).