From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.bugs Subject: Re: bug#141: Process sentinel not called in batch mode Date: Sat, 17 May 2008 23:45:48 -0400 Message-ID: References: <87hcd1kcmz.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211082384 11409 80.91.229.12 (18 May 2008 03:46:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 May 2008 03:46:24 +0000 (UTC) Cc: 141@emacsbugs.donarmstrong.com, rms@gnu.org, cyd@stupidchicken.com, eller.helmut@gmail.com, emacs-devel@gnu.org, bug-submit-list@donarmstrong.com, bug-gnu-emacs@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 18 05:46:58 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JxZrL-0007Pz-GV for ged-emacs-devel@m.gmane.org; Sun, 18 May 2008 05:46:55 +0200 Original-Received: from localhost ([127.0.0.1]:55034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JxZqb-0000Zx-Iq for ged-emacs-devel@m.gmane.org; Sat, 17 May 2008 23:46:09 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JxZqY-0000ZJ-Dh for emacs-devel@gnu.org; Sat, 17 May 2008 23:46:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JxZqX-0000YB-0a for emacs-devel@gnu.org; Sat, 17 May 2008 23:46:06 -0400 Original-Received: from [199.232.76.173] (port=34248 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JxZqW-0000Y7-Uv for emacs-devel@gnu.org; Sat, 17 May 2008 23:46:04 -0400 Original-Received: from 206-248-170-48.dsl.teksavvy.com ([206.248.170.48]:45323 helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JxZqW-0004kg-Oh for emacs-devel@gnu.org; Sat, 17 May 2008 23:46:04 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8BFA7B41C9; Sat, 17 May 2008 23:45:48 -0400 (EDT) In-Reply-To: (Eli Zaretskii's message of "Fri, 16 May 2008 23:07:44 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97346 gmane.emacs.bugs:18039 Archived-At: >> >> >> This side I understand, but what about the other: why should we not >> >> >> check process status in the case where we are not redisplaying? >> >> >> >> > Because Emacs generally looks at process output only when it's idle? >> >> >> >> I don't follow: we're talking about when should >> >> wait_reading_process_output check status_notify. >> >> >> >> So to repeat/rephrase my question: why doesn't >> >> wait_reading_process_output call status_notify when it is passed a zero >> >> do_display? >> >> > Sorry, let me explain my line of thought in more detail: Emacs only >> > does a redisplay when it is idle. Emacs also checks input from >> > subprocesses when it is idle. If we are not in redisplay, it means >> > Emacs is not idle, and so it makes sense not to check for subprocess >> > output at that time. >> >> > Does this make any sense? >> >> But if we're in wait_reading_process_output, that means that idle or >> not, we're checking for process output, so why not check for process >> status changes as well? > Because status_notify has a side effect of triggering redisplay. Thanks. Now it makes a lot more sense. Please add a corresponding comment on the do_display check. Stefan