unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: How are VC switches supposed to work?
Date: Tue, 02 Dec 2008 10:29:14 -0500	[thread overview]
Message-ID: <jwv1vwqzjex.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <50abbff1m0.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 02 Dec 2008 03:00:23 -0500")

> VC switches don't work as they are documented to work.
> If someone can confirm that they work correctly, I will try to update
> the many incorrect pieces of documentation. If on the other hand the
> documentation is correct then the code needs fixing.

> The documentation says that switches are appended. For example:

> C-h v vc-diff-switches
> C-h f vc-cvs-register
> The Emacs manual "Examining And Comparing Old Revisions"

> all say that it works, eg, as: vc-cvs-diff-switches +
> vc-diff-switches + diff-switches.


> In practice, (almost) everywhere uses the vc-switches function to
> process switches. This does no appending, it simply returns the first
> non-nil element.

> For example:

> (setq vc-cvs-diff-switches "-a"
>       vc-diff-switches "-b"
>       diff-switches "-c")

> (vc-switches 'CVS 'diff)
> -> '("-a")

> The situation was basically the same (ie inconsistent) in Emacs 22 AFAICS.

I can't remember all the details, but I do remember that appending is
not good enough because you may have switches in diff-switches that are
not accepted by some backends.


        Stefan




  reply	other threads:[~2008-12-02 15:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02  8:00 How are VC switches supposed to work? Glenn Morris
2008-12-02 15:29 ` Stefan Monnier [this message]
2008-12-02 19:24   ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1vwqzjex.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).