From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Possible emacs bug when type password fields Date: Wed, 06 May 2009 10:25:37 -0400 Message-ID: References: <1f62569f0905010413k13fde32fsbcd1ebef8f872516@mail.gmail.com> <20090501.184211.227773522.hanche@math.ntnu.no> <87k54vtn0j.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1241619959 30321 80.91.229.12 (6 May 2009 14:25:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 May 2009 14:25:59 +0000 (UTC) Cc: Harald Hanche-Olsen , Borja Tarraso , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 06 16:25:49 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M1i4C-0005Ou-Lf for ged-emacs-devel@m.gmane.org; Wed, 06 May 2009 16:25:48 +0200 Original-Received: from localhost ([127.0.0.1]:44451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1i4C-0004Pn-1L for ged-emacs-devel@m.gmane.org; Wed, 06 May 2009 10:25:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1i46-0004NK-Gq for emacs-devel@gnu.org; Wed, 06 May 2009 10:25:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1i42-0004Hv-R7 for emacs-devel@gnu.org; Wed, 06 May 2009 10:25:42 -0400 Original-Received: from [199.232.76.173] (port=56391 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1i42-0004HR-BF for emacs-devel@gnu.org; Wed, 06 May 2009 10:25:38 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:57791) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1i41-0002lI-W2 for emacs-devel@gnu.org; Wed, 06 May 2009 10:25:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUFAJw6AUrO+IYe/2dsb2JhbACBUL9GkBOCVIEtBYVO X-IronPort-AV: E=Sophos;i="4.40,302,1238990400"; d="scan'208";a="38068303" Original-Received: from 206-248-134-30.dsl.teksavvy.com (HELO pastel.home) ([206.248.134.30]) by ironport2-out.teksavvy.com with ESMTP; 06 May 2009 10:25:37 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4872A7F75; Wed, 6 May 2009 10:25:37 -0400 (EDT) In-Reply-To: (Andreas Schwab's message of "Wed, 06 May 2009 10:57:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110724 Archived-At: >> --- lisp/subr.el 2009-05-02 00:32:01 +0000 >> +++ lisp/subr.el 2009-05-06 01:21:02 +0000 >> @@ -1997,10 +1997,11 @@ >> (and (arrayp pass) (clear-string pass)) >> (setq pass new-pass)))) >> ((not (numberp c))) >> - ((= c ?\C-u) ; kill line >> + ((eq c ?\C-u) ; kill line > That should not make a difference, since c is guaranteed to be a number > here. That's the thing: by changing red-char into read-key (done by the previous patch), it is not guaranteed any more. Stefan