From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: ewoc patch Date: Wed, 09 Dec 2009 16:25:10 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1260393951 18638 80.91.229.12 (9 Dec 2009 21:25:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 9 Dec 2009 21:25:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Tom Breton \(Tehom\)" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 09 22:25:44 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NIU2U-0001fJ-1K for ged-emacs-devel@m.gmane.org; Wed, 09 Dec 2009 22:25:38 +0100 Original-Received: from localhost ([127.0.0.1]:47561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIU2T-0000cF-Tf for ged-emacs-devel@m.gmane.org; Wed, 09 Dec 2009 16:25:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIU27-0000OI-H8 for emacs-devel@gnu.org; Wed, 09 Dec 2009 16:25:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIU24-0000ML-1m for emacs-devel@gnu.org; Wed, 09 Dec 2009 16:25:15 -0500 Original-Received: from [199.232.76.173] (port=51814 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIU23-0000MA-OX for emacs-devel@gnu.org; Wed, 09 Dec 2009 16:25:11 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:49265 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NIU23-0000UW-Hs for emacs-devel@gnu.org; Wed, 09 Dec 2009 16:25:11 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEAHqkH0vO+INN/2dsb2JhbACBTNVJhCwEihs X-IronPort-AV: E=Sophos;i="4.47,370,1257138000"; d="scan'208";a="51132082" Original-Received: from 206-248-131-77.dsl.teksavvy.com (HELO pastel.home) ([206.248.131.77]) by ironport2-out.pppoe.ca with ESMTP; 09 Dec 2009 16:25:10 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 87D588065; Wed, 9 Dec 2009 16:25:10 -0500 (EST) In-Reply-To: (Tom Breton's message of "Wed, 9 Dec 2009 15:57:35 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118488 Archived-At: > Fair enough. But ISTM that while `ewoc-for-each' can have the same > signature as `ewoc-map' has now, `ewoc-do' would be expected to have a > signature like dolist and dotimes. Ie, to be used like: > (ewoc-do (element ewoc) > (do-stuff-to element)) > So ewoc-for-each was just an alias but ewoc-do would require more. Sure. I don't have a strong opinion on that one. >> The Emacs package generally doesn't like version numbers, so I'd rather >> not introduce one here, unless there's really a good reason for it. > I added it so that other packages that wanted or needed a variable > separator could tell whether it was available. Otherwise they would make > errors if an old ewoc.el was loaded. If you have a better way in mind, > I'll use it. Better just try to use the feature and detect when it's not available. E.g. check the feature's presence via `fboundp' or by trying the call with the extra parametwer and catch the `wrong-number-of-arguments' error. >> We still don't have a testsuite in Emacs, but we'll gladly add the >> testsuite to our repository (we have a `test' subdirectory for that). > Sure. But it uses my tester package rtest; there is an old version of > rtest out there but I'm using my new version that is still in flux. > (Which, circularly, is the reason I wanted to make ewoc more flexible) I understand. It's OK if the tests can't be run as-is. >>> diff -c -b /home/tehom/emacs-21.4/lisp/emacs-lisp/ewoc.el >>> /home/tehom/projects/emtest/lisp/viewe > Will emacs 22.2 be sufficient? No, please use the latest CVS version. It's not like it's hard to get from the browse-cvs area. Stefan