unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ; ###autoload" cookies
       [not found] <E1NzYsW-0004b6-N5@internal.in.savannah.gnu.org>
@ 2010-04-07 19:01 ` Stefan Monnier
  2010-04-07 20:36   ` Sam Steingold
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2010-04-07 19:01 UTC (permalink / raw)
  To: Sam Steingold; +Cc: emacs-devel

> +;;;###autoload
>  (defun turn-on-bug-reference-mode ()
[...] 
> +;;;###autoload
>  (defun turn-on-bug-reference-prog-mode ()

As discussed recently on emacs-devel, I'd like to discourage/obsolete
the use of turn-(on|off)-foo-mode, so adding ;;;###autoload cookies
there is not a good idea now.


        Stefan




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ;  ###autoload" cookies
  2010-04-07 19:01 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ; ###autoload" cookies Stefan Monnier
@ 2010-04-07 20:36   ` Sam Steingold
  2010-04-09  3:13     ` [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ; Stefan Monnier
  0 siblings, 1 reply; 5+ messages in thread
From: Sam Steingold @ 2010-04-07 20:36 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

On 4/7/10, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> > +;;;###autoload
>  >  (defun turn-on-bug-reference-mode ()
>  [...]
>  > +;;;###autoload
>  >  (defun turn-on-bug-reference-prog-mode ()
>
>  As discussed recently on emacs-devel, I'd like to discourage/obsolete
>  the use of turn-(on|off)-foo-mode, so adding ;;;###autoload cookies
>  there is not a good idea now.

does this mean that
(add-hook 'change-log-mode-hook 'bug-reference-mode)
will DTRT?

-- 
Sam Steingold <http://sds.podval.org>




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ;
  2010-04-07 20:36   ` Sam Steingold
@ 2010-04-09  3:13     ` Stefan Monnier
  2010-04-09 15:55       ` Sam Steingold
  0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2010-04-09  3:13 UTC (permalink / raw)
  To: Sam Steingold; +Cc: emacs-devel

> does this mean that
> (add-hook 'change-log-mode-hook 'bug-reference-mode)
> will DTRT?

Yes,


        Stefan




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ;
  2010-04-09  3:13     ` [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ; Stefan Monnier
@ 2010-04-09 15:55       ` Sam Steingold
  2010-04-10  1:05         ` Stefan Monnier
  0 siblings, 1 reply; 5+ messages in thread
From: Sam Steingold @ 2010-04-09 15:55 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier wrote:
>> does this mean that
>> (add-hook 'change-log-mode-hook 'bug-reference-mode)
>> will DTRT?
> 
> Yes,

OK, I removed the two turn-on-* functions.
thanks for the enlightening and sorry about the churn.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ;
  2010-04-09 15:55       ` Sam Steingold
@ 2010-04-10  1:05         ` Stefan Monnier
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2010-04-10  1:05 UTC (permalink / raw)
  To: Sam Steingold; +Cc: emacs-devel

>>> does this mean that
>>> (add-hook 'change-log-mode-hook 'bug-reference-mode)
>>> will DTRT?
>> Yes,
> OK, I removed the two turn-on-* functions.
> thanks for the enlightening and sorry about the churn.

No problem at all, thank you,


        Stefan




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-04-10  1:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1NzYsW-0004b6-N5@internal.in.savannah.gnu.org>
2010-04-07 19:01 ` [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ; ###autoload" cookies Stefan Monnier
2010-04-07 20:36   ` Sam Steingold
2010-04-09  3:13     ` [Emacs-diffs] /srv/bzr/emacs/trunk r99849: add "; ; ; Stefan Monnier
2010-04-09 15:55       ` Sam Steingold
2010-04-10  1:05         ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).