Use of make-local-variable in a let-binding

Use of make-local-variable in a let-binding

[Thierry Volpiatto]

Hi,
on the emacs build of today, i have an error in anything.el that never
appear in precedent version of emacs:
It tell me that we can't use (set (make-local-variable)...
inside a let-bind.
After having this error once, i have no more error when i do same
command(opening the action buffer in anything).
You can reproduce that by starting emacs with a minimal config of
anything like:
emacs -Q
(add-to-list 'load-path "path/to/anything")
(require 'anything)
and then M-x anything RET TAB
==>
anything-select-action: Making anything-sources local to *anything
action* while let-bound!

If you do M-x anything RET TAB again everything work as normal.

So is it a new behavior or a bug in emacs?

-- 
Thierry Volpiatto
Gpg key: http://pgp.mit.edu/

Re: Use of make-local-variable in a let-binding

[Stefan Monnier]

> on the emacs build of today, i have an error in anything.el that never
> appear in precedent version of emacs:
> It tell me that we can't use (set (make-local-variable)...
> inside a let-bind.

Oh, sorry, it was supposed to be a warning, not an error.
Still: try and fix the code so as not to do that because it's asking
for trouble (even more so when `let' binds per-thread as in the
concurrent branch).

> So is it a new behavior or a bug in emacs?

I think it's a feature, but I know that backward compatibility is a more
important feature.

Should be "fixed" now, thanks,


        Stefan

Re: Use of make-local-variable in a let-binding

[Thierry Volpiatto]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> on the emacs build of today, i have an error in anything.el that never
>> appear in precedent version of emacs:
>> It tell me that we can't use (set (make-local-variable)...
>> inside a let-bind.
>
> Oh, sorry, it was supposed to be a warning, not an error.
> Still: try and fix the code so as not to do that because it's asking
> for trouble (even more so when `let' binds per-thread as in the
> concurrent branch).
Ok i sent that to Rubikitch.

>> So is it a new behavior or a bug in emacs?
>
> I think it's a feature, but I know that backward compatibility is a more
> important feature.
>
> Should be "fixed" now, thanks,
Thanks Stefan.

-- 
Thierry Volpiatto
Gpg key: http://pgp.mit.edu/