unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Juri Linkov <juri@jurta.org>
Cc: ams@gnu.org, emacs-devel@gnu.org
Subject: Re: compile.el: save compile-command
Date: Fri, 23 Apr 2010 10:36:51 -0400	[thread overview]
Message-ID: <jwv1ve6tezi.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87iq7ia7g6.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 23 Apr 2010 11:37:37 +0300")

>> (insert "-*- mode: " name-of-mode
>> "; default-directory: " (prin1-to-string default-directory)
>> +		"; compile-command: " (prin1-to-string command)
>> " -*-\n"
>> -		(format "%s started at %s\n\n"
>> +		(format "%s started at %s\n"
>> mode-name
>> -			(substring (current-time-string) 0 19))
>> -		command "\n")
>> +			(substring (current-time-string) 0 19)) "\n")

> The idea is good, but the output is very ugly: the first line becomes
> too long, and the compile command is no more easy to find and read.

Actually, the other problem is that it's redundant: the compile command
is then printed twice at the beginning of the buffer.  I'd rather tweak
the current format so that the already printed command can be extracted
reliably and then -*- compilation -*- will be sufficient (assuming
compilation-mode can then look for the command and set the
compile-command var appropriately).

> Since your intention was to save the command as a file local variable,
> what do you think about putting an `invisible' property over the added
> `compile-command' in the first line?

Using `invisible' is always asking for trouble, so I'd rather try other
options first.


        Stefan




  parent reply	other threads:[~2010-04-23 14:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22 14:57 compile.el: save compile-command Alfred M. Szmidt
2010-04-23  8:37 ` Juri Linkov
2010-04-23 14:31   ` Alfred M. Szmidt
2010-04-23 14:36   ` Stefan Monnier [this message]
2010-04-23 16:54     ` Juri Linkov
2010-04-23 15:00   ` Davis Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1ve6tezi.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=ams@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).