From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: CEDET non-regression bug fixes Date: Wed, 14 Nov 2012 16:16:48 -0500 Message-ID: References: <87k3tprzss.fsf@engster.org> <876258rp28.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1352927827 10391 80.91.229.3 (14 Nov 2012 21:17:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Nov 2012 21:17:07 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 14 22:17:18 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TYkKa-0008Gq-9A for ged-emacs-devel@m.gmane.org; Wed, 14 Nov 2012 22:17:08 +0100 Original-Received: from localhost ([::1]:58735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYkKQ-0005T2-C1 for ged-emacs-devel@m.gmane.org; Wed, 14 Nov 2012 16:16:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYkKM-0005Sc-BD for emacs-devel@gnu.org; Wed, 14 Nov 2012 16:16:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYkKJ-0001pz-9A for emacs-devel@gnu.org; Wed, 14 Nov 2012 16:16:54 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:35855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYkKJ-0001pt-51 for emacs-devel@gnu.org; Wed, 14 Nov 2012 16:16:51 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09sr+ZY/2dsb2JhbABEtBGBCIIVAQEEAVYeCgsLNBIUGA2IQAW6CY0mgx4DiEKacYFYgwc X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="207628538" Original-Received: from 108-175-230-88.dsl.teksavvy.com (HELO pastel.home) ([108.175.230.88]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 14 Nov 2012 16:16:49 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id C585A594C8; Wed, 14 Nov 2012 16:16:48 -0500 (EST) In-Reply-To: <876258rp28.fsf@engster.org> (David Engster's message of "Wed, 14 Nov 2012 19:56:31 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154864 Archived-At: >>> + (with-selected-window (get-buffer-window "*Completions*") >>> + (if (posn-at-point (point-max)) >>> + (goto-char (point-min)) >>> + (scroll-up)))) >> This will signal an error when *Completions* is not displayed anywhere. Actually, it's worse: it will signal an error when *Completions* is not displayed in the selected frame. IOW in my config it will always signal an error. > At this stage, there must be a *Completions* buffer, otherwise it's an > error anyway. But regarding the freeze, I will wrap something around > that making sure it exists. I'd rather keep this for trunk: - it's not safe. - It's not a regression. - It's not even a bug fix: it improves behavior more than it fixes a bug. >>> - (buff (get-file-buffer file)) >>> + (buff (find-buffer-visiting file)) >> We need to do something to avoid those problems. AFAIK there's no >> reason to ever prefer get-file-buffer over find-buffer-visiting, so >> maybe we should simply get rid of get-file-buffer and make it an alias >> of find-buffer-visiting. > Oh, you have my vote for that. Great! How much (time and effort) are you willing to contribute to my campaign? > But I have a hunch you won't put this change into the emacs-24 branch, Huh? How did you guess? > so I read this comment as "Fine, please commit". ;-) Indeed, Stefan