From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r117286: Fix last commit. Date: Mon, 09 Jun 2014 12:19:42 -0400 Message-ID: References: <83mwdn31yg.fsf@gnu.org> <5394ABD6.1040100@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402330849 1733 80.91.229.3 (9 Jun 2014 16:20:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Jun 2014 16:20:49 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 09 18:20:41 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wu2JM-0000hm-Bh for ged-emacs-devel@m.gmane.org; Mon, 09 Jun 2014 18:20:40 +0200 Original-Received: from localhost ([::1]:34328 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wu2JL-0005gY-Tn for ged-emacs-devel@m.gmane.org; Mon, 09 Jun 2014 12:20:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wu2J8-0005f9-Qi for emacs-devel@gnu.org; Mon, 09 Jun 2014 12:20:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wu2J0-0002CU-JO for emacs-devel@gnu.org; Mon, 09 Jun 2014 12:20:26 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:33740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wu2Is-0002B6-02; Mon, 09 Jun 2014 12:20:10 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 7893024144; Mon, 9 Jun 2014 12:20:09 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 591661E5B74; Mon, 9 Jun 2014 12:19:42 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 3AB06B4167; Mon, 9 Jun 2014 12:19:42 -0400 (EDT) In-Reply-To: <5394ABD6.1040100@cs.ucla.edu> (Paul Eggert's message of "Sun, 08 Jun 2014 11:30:46 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 132.204.24.67 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172422 Archived-At: >>> I wish people could refrain from playing around with the >>> >static/extern declarations. >> I didn't. I just fixed something that was already there. This was not directed at you in particular, indeed. > I think Stefan was referring to the practice of marking symbols as > static if they're not used in other modules. Right. > Generally speaking this is good practice, as non-expert readers of the > code needn't consider whether a static symbol might be used by another > module. It can help GCC in the same way. Yes, but for things which are conceptually global (e.g. all the Qfoo thingies, which by convention share namespace with Elisp's), the fact they are currently only accessed from a single file doesn't mean it will (or even should) stay that way, and adding "static" when that changes is pointless (and just means we'll have to remove that "static" next time it changes). > However, I take Stefan's point that the practice gets messy when dealing > with functions that can be static on typical GNU/Linux builds but must be > extern on other ports. So I installed trunk bzr 117290 to make these > symbols extern. Yes, that's better. Stefan