From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master f7572b7: Fix Semantic completion-at-point functions in non-Semantic buffers Date: Sun, 14 Dec 2014 17:51:32 -0500 Message-ID: References: <20141214105944.8359.64300@vcs.savannah.gnu.org> <548DA0E3.6090008@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418597517 30270 80.91.229.3 (14 Dec 2014 22:51:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Dec 2014 22:51:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 14 23:51:50 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y0I10-000386-IG for ged-emacs-devel@m.gmane.org; Sun, 14 Dec 2014 23:51:50 +0100 Original-Received: from localhost ([::1]:37361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0I10-00066W-7R for ged-emacs-devel@m.gmane.org; Sun, 14 Dec 2014 17:51:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0I0q-00066P-LN for emacs-devel@gnu.org; Sun, 14 Dec 2014 17:51:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0I0j-00073C-5i for emacs-devel@gnu.org; Sun, 14 Dec 2014 17:51:40 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:48431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0I0j-000732-2M for emacs-devel@gnu.org; Sun, 14 Dec 2014 17:51:33 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AskIAOwQflTO+ILA/2dsb2JhbABbgweDYMp3BAICgSQXAQEBAQEBfIQDAQEDAVYjEAsOJgcLFBgNJIhKCdZZAQEBAQYBAQEBHpBvB4RIBYsBpC6BeII3gWIhgncBAQE X-IPAS-Result: AskIAOwQflTO+ILA/2dsb2JhbABbgweDYMp3BAICgSQXAQEBAQEBfIQDAQEDAVYjEAsOJgcLFBgNJIhKCdZZAQEBAQYBAQEBHpBvB4RIBYsBpC6BeII3gWIhgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="101691050" Original-Received: from 206-248-130-192.dsl.teksavvy.com (HELO pastel.home) ([206.248.130.192]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 14 Dec 2014 17:51:32 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 576BE25A8; Sun, 14 Dec 2014 17:51:32 -0500 (EST) In-Reply-To: <548DA0E3.6090008@yandex.ru> (Dmitry Gutov's message of "Sun, 14 Dec 2014 16:38:27 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180111 Archived-At: >> Looks like the wrong fix. Don't you think the right fix would be to >> change the add/remove-hooks in semantic-mode so that they are >> buffer-local? > `semantic-mode' is global, Duh! Sorry for being dense, and thanks for the fix, Stefan