From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0679159: Use the VC root in `log-edit-listfun' Date: Fri, 10 Apr 2015 02:33:47 -0400 Message-ID: References: <20150410010013.30467.14459@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1428647658 5795 80.91.229.3 (10 Apr 2015 06:34:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Apr 2015 06:34:18 +0000 (UTC) Cc: Dmitry Gutov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 10 08:34:07 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YgSVz-0006Vr-1P for ged-emacs-devel@m.gmane.org; Fri, 10 Apr 2015 08:34:07 +0200 Original-Received: from localhost ([::1]:37662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgSVy-0007O2-6J for ged-emacs-devel@m.gmane.org; Fri, 10 Apr 2015 02:34:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgSVl-0007Nu-Il for emacs-devel@gnu.org; Fri, 10 Apr 2015 02:33:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YgSVi-00051x-Bs for emacs-devel@gnu.org; Fri, 10 Apr 2015 02:33:53 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:58955) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YgSVi-00051s-7Q for emacs-devel@gnu.org; Fri, 10 Apr 2015 02:33:50 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t3A6Xllh016862; Fri, 10 Apr 2015 02:33:48 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 8F7CF2238; Fri, 10 Apr 2015 02:33:47 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Fri, 10 Apr 2015 01:02:07 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5271=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5271> : inlines <2674> : streams <1419984> : uri <1903102> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185242 Archived-At: >> + ;; FIXME: Should expand the list for directories. >> + ;; Is the above still relevant? If so, it needs a >> + ;; better explanation. -- dgutov > I think that for the use case in Emacs's master it is not really > relevant any more because there's only a single ChangeLog. Actually, no: it is still relevant. > The problem was as follows: > - mark "." in vc-dir then do C-x v v to commit changes to a few lisp files. > - be disappointed that the log-edit buffer was not pre-filled with the > corresponding entries in lisp/ChangeLog because lisp/ChangeLog is not > the right file for "." and log-edit doesn't know that the files that > will be committed are somewhere underneath the `lisp' subdirectory. The remaining problem is that when marking ".", log-edit may find the right ./ChangeLog file but without knowing which files in "." will be committed, it can't know which entries to select. Stefan