From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Samer Masterson <samer@samertm.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] switch to file buffer from command line args regardless of `initial-buffer-choice'
Date: Wed, 20 May 2015 14:36:48 -0400 [thread overview]
Message-ID: <jwv1tibgl0l.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87oall2p4o.fsf@f-box.i-did-not-set--mail-host-address--so-tickle-me> (Samer Masterson's message of "Fri, 15 May 2015 20:11:03 -0700")
>> After it's finished processing the command line args, it switches to the
>> buffer `initial-buffer-choice'. It does not open the startup screen if
>> `initial-buffer-choice' is non-nil, and it does not switch to any files.
>> It will open *Buffers List* if three or more files are given to it.
>>
>> The behavior with my patch: If Emacs is given one file arg, it's opened
>> alongside `initial-buffer-choice'.
Hmm... shouldn't it just display that file's buffer and ignore
initial-buffer-choice? Wait, I see the doc says:
displayed. If ‘initial-buffer-choice’ is non-‘nil’, then if you specify
any files on the command line, Emacs still visits them, but does not
display them initially.
So I guess no, we shouldn't ignore initial-buffer-choice when there are
files specified on the command line. So your patch will require
updating the doc, but I think the behavior it provides is good.
>> If Emacs is given two or more file args, then it will display
>> `initial-buffer-choice' and *Buffer List*, which is consistent with
>> the current behavior when `initial-buffer-choice' is nil and Emacs is
>> given more files than it can display.
Sounds good.
>> Thanks in advance for the review!
You're welcome. Feel free to install it.
I hope my review wasn't too prompt, tho,
Stefan
next prev parent reply other threads:[~2015-05-20 18:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 8:07 [PATCH] switch to file buffer from command line args regardless of `initial-buffer-choice' Samer Masterson
2015-03-13 22:11 ` Stefan Monnier
2015-05-01 14:17 ` Samer Masterson
2015-05-16 3:11 ` Samer Masterson
2015-05-20 18:36 ` Stefan Monnier [this message]
2015-05-28 21:34 ` Samer Masterson
2015-05-29 5:48 ` Eli Zaretskii
2015-05-29 8:02 ` Samer Masterson
2015-08-03 14:56 ` Rasmus
[not found] ` <CAP6_t8gsmwPj5vkBQ4eegYXYcfmVAtHb+mnrUMYPyZwDXZ8DRw@mail.gmail.com>
[not found] ` <CAP6_t8gDr0y_WvwO43nXOFLU5h4hC-nnpjAmC-wDe7dYcTuwyw@mail.gmail.com>
[not found] ` <874mkdjwt8.fsf@gmx.us>
2015-08-05 20:46 ` Samer Masterson
2015-08-07 15:33 ` Stefan Monnier
2015-08-07 17:42 ` Samer Masterson
2015-08-07 17:42 ` Samer Masterson
2015-08-07 21:22 ` Stefan Monnier
2015-08-10 18:16 ` Samer Masterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1tibgl0l.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=samer@samertm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).