From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Alexey Veretennikov <alexey.veretennikov@gmail.com>
Subject: Re: [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master'
Date: Sat, 13 Jun 2015 10:23:37 -0400 [thread overview]
Message-ID: <jwv1thfk7v6.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1Z3Tzw-00063x-5G@vcs.savannah.gnu.org> (Alexey Veretennikov's message of "Fri, 12 Jun 2015 18:48:12 +0000")
> -;; Compatibility: GNU Emacs GNU Emacs 24.x
> +;; Compatibility: GNU Emacs 24.x
So is it OK if I change those files to use lexical-binding?
> (defun newline-and-begin ()
> "Move a point to the beginning of the next line."
> - (newline)
> + (insert "\n")
> (beginning-of-line))
The beginning-of-line can be removed as well (at which point you're
better off removing newline-and-begin altogether and simply replace every
call by (insert "\n")).
One more thing: I see that ztree-util.el defines several functions (such
as the one here) without a "ztree-" prefix. It would be good to fix this.
Stefan
next parent reply other threads:[~2015-06-13 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150612184810.23227.21127@vcs.savannah.gnu.org>
[not found] ` <E1Z3Tzw-00063x-5G@vcs.savannah.gnu.org>
2015-06-13 14:23 ` Stefan Monnier [this message]
2015-06-13 20:55 ` [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master' Alexey Veretennikov
2015-06-14 3:05 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1thfk7v6.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=alexey.veretennikov@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).