From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Compilation warnings in mouse.el Date: Wed, 13 Jul 2016 11:42:45 -0400 Message-ID: References: <8360scdzik.fsf@gnu.org> <87zipnzvo4.fsf@gmx.net> <8337nfcupy.fsf@gnu.org> <83inw9a9tl.fsf@gnu.org> <83wpkp8s9g.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468424775 25242 80.91.229.3 (13 Jul 2016 15:46:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 15:46:15 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 13 17:46:06 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNMMP-00039O-Ho for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 17:46:05 +0200 Original-Received: from localhost ([::1]:48491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNMMO-0006mb-PS for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 11:46:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNMLV-0006ld-09 for emacs-devel@gnu.org; Wed, 13 Jul 2016 11:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNMLS-0003Se-3o for emacs-devel@gnu.org; Wed, 13 Jul 2016 11:45:08 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:52058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNMLR-0003SB-TK for emacs-devel@gnu.org; Wed, 13 Jul 2016 11:45:06 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bNMLR-0002SE-35 for emacs-devel@gnu.org; Wed, 13 Jul 2016 17:45:05 +0200 Original-Received: from 69-165-156-121.dsl.teksavvy.com ([69.165.156.121]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2016 17:45:05 +0200 Original-Received: from monnier by 69-165-156-121.dsl.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2016 17:45:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 20 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69-165-156-121.dsl.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:zAcV6d8vuor2qN3wDDNuIJ/PEmo= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205648 Archived-At: > No, I meant a system where one doesn't have to do anything to have a > group for a defcustom. Nothing at all. I guess we could do that, but I think we'd hear even more screams. > If they must first check if there's a defgroup in the same file, and The byte-compiler will complain if a defcustom doesn't have a :group and there's no preceding defgroup (as was the case in the situation that started this discussion). So I don't think it's too much of a problem. > then if there's more than one defgroup, make sure the defcustom is > after the right one, then this is an error-prone system which cannot > be trusted. Then let's restrict the current system so it also complains if there's no :group yet there are more than one preceding defgroup. Stefan