unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Compilation warnings in mouse.el
Date: Wed, 13 Jul 2016 11:42:45 -0400	[thread overview]
Message-ID: <jwv1t2xv96v.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 83wpkp8s9g.fsf@gnu.org

> No, I meant a system where one doesn't have to do anything to have a
> group for a defcustom.  Nothing at all.

I guess we could do that, but I think we'd hear even more screams.

> If they must first check if there's a defgroup in the same file, and

The byte-compiler will complain if a defcustom doesn't have a :group and
there's no preceding defgroup (as was the case in the situation that
started this discussion).  So I don't think it's too much of a problem.

> then if there's more than one defgroup, make sure the defcustom is
> after the right one, then this is an error-prone system which cannot
> be trusted.

Then let's restrict the current system so it also complains if there's
no :group yet there are more than one preceding defgroup.


        Stefan




  reply	other threads:[~2016-07-13 15:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 14:23 Compilation warnings in mouse.el Eli Zaretskii
2016-07-11 21:55 ` Stephen Berman
2016-07-12  5:04   ` Eli Zaretskii
2016-07-12  8:45     ` Stephen Berman
2016-07-12 22:40     ` John Wiegley
2016-07-12 22:58       ` Stefan Monnier
2016-07-13  9:28         ` Joost Kremers
2016-07-13 12:45           ` Stefan Monnier
2016-07-13 14:08             ` Drew Adams
2016-07-13 14:31         ` Eli Zaretskii
2016-07-13 15:12           ` Stefan Monnier
2016-07-13 15:22             ` Drew Adams
2016-07-13 15:37               ` Stefan Monnier
2016-07-13 16:07                 ` Drew Adams
2016-07-13 15:36             ` Eli Zaretskii
2016-07-13 15:42               ` Stefan Monnier [this message]
2016-07-13 16:07                 ` Drew Adams
2016-07-13 16:13                 ` Eli Zaretskii
2016-07-13 16:42                   ` Stefan Monnier
2016-07-12 22:56     ` Dmitry Gutov
2016-07-13 14:30       ` Eli Zaretskii
2016-07-13 14:41         ` Dmitry Gutov
     [not found] <<8360scdzik.fsf@gnu.org>
     [not found] ` <<87zipnzvo4.fsf@gmx.net>
     [not found]   ` <<8337nfcupy.fsf@gnu.org>
2016-07-12 14:04     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1t2xv96v.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).