From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 1b4442b: Don't expand body inside a let-binding when there are no bindings Date: Fri, 17 Feb 2017 19:05:39 -0500 Message-ID: References: <20170216014306.20854.5128@vcs0.savannah.gnu.org> <20170216014308.12DC326007@vcs0.savannah.gnu.org> <878tp58lzt.fsf@holos> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487376363 7526 195.159.176.226 (18 Feb 2017 00:06:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2017 00:06:03 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 18 01:05:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cesXA-0000i3-Ht for ged-emacs-devel@m.gmane.org; Sat, 18 Feb 2017 01:05:52 +0100 Original-Received: from localhost ([::1]:56541 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cesXC-0000Sw-Rt for ged-emacs-devel@m.gmane.org; Fri, 17 Feb 2017 19:05:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cesX3-0000Sn-R3 for emacs-devel@gnu.org; Fri, 17 Feb 2017 19:05:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cesWy-0005Bx-Sn for emacs-devel@gnu.org; Fri, 17 Feb 2017 19:05:45 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:16046) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cesWy-0005Bh-I2 for emacs-devel@gnu.org; Fri, 17 Feb 2017 19:05:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BUBgBbj6dY/03eSC1eDg4BAQQBAQoBAYNRhHaLSJEkKQGXFoYcBAICgiREFAECAQEBAQEBAWIohHEBBAFWIwULCw4mEhQYDSSJdwiybotbAQEBAQYCASWLO4o5BZBFizyTfIhNhliTHjYhgQAgFAgqhTmBDVkii0YBAQE X-IPAS-Result: A0BUBgBbj6dY/03eSC1eDg4BAQQBAQoBAYNRhHaLSJEkKQGXFoYcBAICgiREFAECAQEBAQEBAWIohHEBBAFWIwULCw4mEhQYDSSJdwiybotbAQEBAQYCASWLO4o5BZBFizyTfIhNhliTHjYhgQAgFAgqhTmBDVkii0YBAQE X-IronPort-AV: E=Sophos;i="5.35,173,1484024400"; d="scan'208";a="293180522" Original-Received: from 45-72-222-77.cpe.teksavvy.com (HELO pastel.home) ([45.72.222.77]) by smtp.teksavvy.com with ESMTP; 17 Feb 2017 19:05:41 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 42AEF65019; Fri, 17 Feb 2017 19:05:39 -0500 (EST) In-Reply-To: <878tp58lzt.fsf@holos> (Mark Oteiza's message of "Thu, 16 Feb 2017 23:44:22 -0500") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212440 Archived-At: > In the past I noticed that pcase expanded things to (let nil ...), which > I think is a bit annoying wrt readability, yes; however just recently I > was poking at elint.el, which complains about such forms with > > Empty varlist in let: (let nil ) > > so I was more inclined to change it. OK, thanks. > Between vars possibly being expensive, and--one step beyond that--using an > uninterned symbol to ameliorate evalling vars twice incurring a cost > with dynamic binding, I suppose this change was short sighted. Sorry, I didn't understand this part of your message. Stefan