From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master bd60ee2 1/5: auth-source: factor out parsers and add tests Date: Fri, 28 Apr 2017 08:52:12 -0400 Message-ID: References: <20170427213824.12196.63777@vcs0.savannah.gnu.org> <20170427213827.B6BDC22040@vcs0.savannah.gnu.org> <87mvb0n1nv.fsf@lifelogs.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1493383985 9666 195.159.176.226 (28 Apr 2017 12:53:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 28 Apr 2017 12:53:05 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 28 14:52:55 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d45OH-0002H1-1z for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 14:52:53 +0200 Original-Received: from localhost ([::1]:36922 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d45OM-0004UC-LG for ged-emacs-devel@m.gmane.org; Fri, 28 Apr 2017 08:52:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d45No-0004T2-UZ for emacs-devel@gnu.org; Fri, 28 Apr 2017 08:52:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d45Nl-0007Ld-RL for emacs-devel@gnu.org; Fri, 28 Apr 2017 08:52:24 -0400 Original-Received: from [195.159.176.226] (port=41638 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d45Nl-0007LF-KY for emacs-devel@gnu.org; Fri, 28 Apr 2017 08:52:21 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1d45Ne-0001VW-3O for emacs-devel@gnu.org; Fri, 28 Apr 2017 14:52:14 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:hBrElA2w3tVE/ut3YOaGmHBphMc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214386 Archived-At: > Sorry, I don't know what's the proper fix. What breaks, and how should I > have caught this problem before it was comitted? "make" says: ELC auth-source.elc In toplevel form: auth-source.el:782:1:Warning: Unused lexical variable ‘sym’ auth-source.el:818:1:Warning: Unused lexical variable ‘sym’ auth-source.el:1196:1:Warning: Unused lexical variable ‘ret’ In end of data: auth-source.el:2080:1:Warning: the function ‘return’ is not known to be defined. and while the 3 "unused ..." lines are due to my setting byte-compile-force-lexical-warnings, the last warning should be present for you as well. Stefan