unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Philipp Stephani <phst@google.com>
Subject: Re: [Emacs-diffs] master 34d4720: Electric quotes: Improve support for Markdown mode (Bug#24709)
Date: Sun, 02 Jul 2017 13:48:23 -0400	[thread overview]
Message-ID: <jwv1spy4tra.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20170702154852.1796522E35@vcs0.savannah.gnu.org> (Philipp Stephani's message of "Sun,  2 Jul 2017 11:48:51 -0400 (EDT)")

>     Also introduce a new variable 'electric-quote-code-faces'.  Major
>     modes such as 'markdown-mode' can add faces to this list to treat text
>     as inline code and disable electric quoting.
    
Hmm... FWIW I don't like using faces for that (e.g. it means the
features doesn't work when the user disables font-lock-mode, even in
cases where it's easy to decide what to do based on syntax-ppss for
example).
Why not use a electric-quote-inhibit-function hook instead?


        Stefan



       reply	other threads:[~2017-07-02 17:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170702154850.22058.98643@vcs0.savannah.gnu.org>
     [not found] ` <20170702154852.1796522E35@vcs0.savannah.gnu.org>
2017-07-02 17:48   ` Stefan Monnier [this message]
2017-07-03 16:48     ` [Emacs-diffs] master 34d4720: Electric quotes: Improve support for Markdown mode (Bug#24709) Philipp Stephani
2017-07-03 18:36       ` Stefan Monnier
2017-07-03 19:00         ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1spy4tra.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).