From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Message's text-properties in *Messages*
Date: Wed, 30 May 2018 15:44:08 -0400 [thread overview]
Message-ID: <jwv1sdtueba.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83tvqpgix5.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 May 2018 20:19:50 +0300")
>> I didn't mean to answer all of them yet, I will need some time to look
>> at the code.
> Sorry for the long delay in responding.
Come on, it has barely been a week.
>> - Why would arbitrary Lisp code be dangerous (I understand that message_dolog
>> can be called from within redisplay, but redisplay runs Elisp code
>> at several places, so "from redisplay" doesn't inherently imply you
>> can't run Elisp code).
> As I wrote previously, redisplay is not the issue here, as
> message_dolog doesn't call any redisplay entry points.
Hmm... indeed I'm not worried about message_dolog calling redisplay,
instead I think the worry is about redisplay calling message_dolog
(probably via `message` or some variant thereof).
> . the new function message_dolog_lisp is safe because it accepts a
> Lisp string, not a C 'char *' pointer
If there's no risk of message_dolog(_lisp) being called *from*
redisplay, then indeed message_dolog_lisp should be perfectly safe and
could even skip the inhibit-*-hooks dance (tho we might want to be
careful about those hooks calling `message` recursively).
And in that case, we could also replace message_dolog with
message_dolog_lisp (if needed, building a fresh new Lisp string from
a char*).
Stefan
next prev parent reply other threads:[~2018-05-30 19:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 17:10 edebug: regrettable loss of information in Emacs 26.1 when printing a variable's value Alan Mackenzie
2018-05-21 17:47 ` Noam Postavsky
2018-05-21 18:23 ` Alan Mackenzie
2018-05-21 18:30 ` Eli Zaretskii
2018-05-21 21:20 ` Noam Postavsky
2018-05-22 16:53 ` Eli Zaretskii
2018-05-21 17:58 ` Eli Zaretskii
2018-05-21 19:04 ` Alan Mackenzie
2018-05-21 18:05 ` Stefan Monnier
2018-05-21 21:24 ` Noam Postavsky
2018-05-22 0:52 ` Stefan Monnier
2018-05-23 17:28 ` Stefan Monnier
2018-05-23 16:03 ` Message's text-properties in *Messages* (was: edebug: regrettable loss of information in Emacs 26.1 when printing a variable's value) Stefan Monnier
2018-05-23 16:10 ` Drew Adams
2018-05-23 16:46 ` Message's text-properties in *Messages* Stefan Monnier
2018-05-26 0:48 ` John Wiegley
2018-05-26 15:52 ` Stefan Monnier
2018-05-26 19:50 ` Amin Bandali
2018-05-27 14:36 ` John Wiegley
2018-05-27 21:28 ` Amin Bandali
2018-05-23 17:22 ` Message's text-properties in *Messages* (was: edebug: regrettable loss of information in Emacs 26.1 when printing a variable's value) Eli Zaretskii
2018-05-23 17:41 ` Message's text-properties in *Messages* Stefan Monnier
2018-05-23 18:07 ` Eli Zaretskii
2018-05-30 17:19 ` Eli Zaretskii
2018-05-30 19:44 ` Stefan Monnier [this message]
2018-05-30 19:55 ` Eli Zaretskii
2018-05-31 2:09 ` Stefan Monnier
2018-05-31 2:40 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv1sdtueba.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).