From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master d82e73f: Handle 'unbound' like nil for 'window-point-insertion-type' (Bug#33871) Date: Tue, 01 Jan 2019 23:22:32 -0500 Message-ID: References: <20181230144831.8662.30750@vcs0.savannah.gnu.org> <20181230144832.A6B45209D7@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1546402883 21502 195.159.176.226 (2 Jan 2019 04:21:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 Jan 2019 04:21:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Martin Rudalics To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 02 05:21:18 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1geY1t-0005SP-Bl for ged-emacs-devel@m.gmane.org; Wed, 02 Jan 2019 05:21:17 +0100 Original-Received: from localhost ([127.0.0.1]:41767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1geY3x-0006w5-0U for ged-emacs-devel@m.gmane.org; Tue, 01 Jan 2019 23:23:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1geY3H-0006vg-IL for emacs-devel@gnu.org; Tue, 01 Jan 2019 23:22:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1geY3D-0000R5-Bn for emacs-devel@gnu.org; Tue, 01 Jan 2019 23:22:43 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:54864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1geY3D-0000Ql-75 for emacs-devel@gnu.org; Tue, 01 Jan 2019 23:22:39 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x024MWEK020581; Tue, 1 Jan 2019 23:22:33 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id CB5E3AE92F; Tue, 1 Jan 2019 23:22:32 -0500 (EST) In-Reply-To: <20181230144832.A6B45209D7@vcs0.savannah.gnu.org> (Martin Rudalics's message of "Sun, 30 Dec 2018 09:48:32 -0500 (EST)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6451=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6451> : inlines <6990> : streams <1808878> : uri <2773489> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232077 Archived-At: > * src/window.c (save_window_save): When setting the marker > insertion type of saved window points treat a buffer local > value of 'unbound' for 'window-point-insertion-type' like > nil (Bug#33871). I think treating it like nil is technically incorrect: instead of nil it should use the global value of the variable (like Fbuffer_local_value would). Stefan