From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 12409c9: New transient mode 'repeat-mode' to allow shorter key sequences (bug#46515) Date: Wed, 24 Feb 2021 15:53:58 -0500 Message-ID: References: <20210217180506.28704.14280@vcs0.savannah.gnu.org> <20210217180507.C061220DFB@vcs0.savannah.gnu.org> <87lfbln1w8.fsf@mail.linkov.net> <87h7m9co2d.fsf@mail.linkov.net> <87a6rtl7b3.fsf@mail.linkov.net> <874ki1i73y.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38238"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 24 21:55:21 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lF1Bo-0009qN-8X for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Feb 2021 21:55:20 +0100 Original-Received: from localhost ([::1]:32990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lF1Bn-0003zo-Ae for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Feb 2021 15:55:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lF1Aa-0003Wf-Sj for emacs-devel@gnu.org; Wed, 24 Feb 2021 15:54:04 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lF1AY-0004X1-NR for emacs-devel@gnu.org; Wed, 24 Feb 2021 15:54:04 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 00608441702; Wed, 24 Feb 2021 15:54:01 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B32B24416E8; Wed, 24 Feb 2021 15:53:59 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1614200039; bh=XUG0RmLnMmyEde3yy5f0ALO88fTtMREQ4Asz4zdxnTs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=G0kNd4jI22hYRTwi/bVjajaX4Uj5ISUnEOv8Sx55LJXBBUcF31VzcrI3evXAj7VNs f7NpC8r48cGwTJ0a7GZ93Sm3GF0MqSBIwsWEZWOnIPJ8x29jHLfTAnexXdtULwVjVD eFykq+XW+0WtJXHzJS1N5k6x1ItmKpTEjPwawK2fDG6gcRU2aNiVBaS8faSpVjmxJO NrkR6ziFREkrMGiqR2i1tpu6HPksKd3CnbD0asmPMjG/xtB6iy2447If56K8B0rloI Y70HzaxKjJkTY0sF0S0yl25LnOvGgtWKNhF6H8AfATYTXb3jHl6BqbsToyF1GnKTP9 rV++Ihm5XLLBQ== Original-Received: from alfajor (unknown [216.154.41.47]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7BF26120077; Wed, 24 Feb 2021 15:53:59 -0500 (EST) In-Reply-To: <874ki1i73y.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 24 Feb 2021 21:44:01 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265591 Archived-At: >> I don't understand why you think what I said is related to what you say. >> Some code somewhere installs a transient keymap. *That* code can do >> some extra work to stash that keymap somewhere else as well so you can >> look it up from there instead of having to check the `repeat-map` property. > > The key word is "somewhere". The first somewhere that installs > a transient keymap in post-command-hook needs to get that keymap. > Currently it gets it from the symbol property of this-command. Aahhh.... now I understand. So the `repeat-map` property is actually not redundant: it records which transient keymap to use after that command and that keymap could conceivably not include that command. Also, not all commands in that keymap should trigger the transient use of that keymap. I understand quickly but only after a long explanation. Sorry 'bout that, Stefan